Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: content/public/test/render_view_test.cc

Issue 971653004: Remove the FrameMsg_Navigate_Params (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@history-params
Patch Set: Addressed Nasko's comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/render_view_test.cc
diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc
index a8702109d4458abd74104646147c0e0a4c6a6d18..f0e0f8c011d0b1f33a6ab6abae4c8a770c130afc 100644
--- a/content/public/test/render_view_test.cc
+++ b/content/public/test/render_view_test.cc
@@ -362,11 +362,14 @@ void RenderViewTest::SetFocused(const blink::WebNode& node) {
}
void RenderViewTest::Reload(const GURL& url) {
- FrameMsg_Navigate_Params params;
- params.common_params.url = url;
- params.common_params.navigation_type = FrameMsg_Navigate_Type::RELOAD;
+ CommonNavigationParams common_params(
+ url, Referrer(), ui::PAGE_TRANSITION_LINK, FrameMsg_Navigate_Type::RELOAD,
+ true, base::TimeTicks(), FrameMsg_UILoadMetricsReportType::NO_REPORT,
+ GURL(), GURL());
RenderViewImpl* impl = static_cast<RenderViewImpl*>(view_);
- impl->GetMainRenderFrame()->OnNavigate(params);
+ impl->GetMainRenderFrame()->OnNavigate(common_params, StartNavigationParams(),
+ CommitNavigationParams(),
+ HistoryNavigationParams());
FrameLoadWaiter(impl->GetMainRenderFrame()).Wait();
}
@@ -440,22 +443,17 @@ void RenderViewTest::GoToOffset(int offset, const PageState& state) {
impl->historyForwardListCount() + 1;
int pending_offset = offset + impl->history_list_offset_;
- FrameMsg_Navigate_Params navigate_params;
- navigate_params.common_params.navigation_type =
- FrameMsg_Navigate_Type::NORMAL;
- navigate_params.common_params.transition = ui::PAGE_TRANSITION_FORWARD_BACK;
- navigate_params.history_params.current_history_list_length =
- history_list_length;
- navigate_params.history_params.current_history_list_offset =
- impl->history_list_offset_;
- navigate_params.history_params.pending_history_list_offset = pending_offset;
- navigate_params.history_params.page_id = impl->page_id_ + offset;
- navigate_params.history_params.page_state = state;
- navigate_params.request_time = base::Time::Now();
-
- FrameMsg_Navigate navigate_message(impl->GetMainRenderFrame()->GetRoutingID(),
- navigate_params);
- impl->GetMainRenderFrame()->OnMessageReceived(navigate_message);
+ CommonNavigationParams common_params(
+ GURL(), Referrer(), ui::PAGE_TRANSITION_FORWARD_BACK,
+ FrameMsg_Navigate_Type::NORMAL, true, base::TimeTicks(),
+ FrameMsg_UILoadMetricsReportType::NO_REPORT, GURL(), GURL());
+ HistoryNavigationParams history_params(
+ state, impl->page_id_ + offset, pending_offset,
+ impl->history_list_offset_, history_list_length, false);
+
+ impl->GetMainRenderFrame()->OnNavigate(common_params, StartNavigationParams(),
+ CommitNavigationParams(),
+ history_params);
// The load actually happens asynchronously, so we pump messages to process
// the pending continuation.

Powered by Google App Engine
This is Rietveld 408576698