Remove the FrameMsg_Navigate_Params

content/browser/frame_host/render_frame_host_impl.h

Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index dc6c42b32025bddf8ee3381cf759aece36aab3e3..73c2b593ed9a2e2a030f26077d5e303d34946f90 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -21,6 +21,7 @@
 #include "content/common/frame_message_enums.h"
 #include "content/common/frame_replication_state.h"
 #include "content/common/mojo/service_registry_impl.h"
+#include "content/common/navigation_params.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/common/javascript_message_type.h"
 #include "net/http/http_response_headers.h"
@@ -38,8 +39,6 @@ struct AccessibilityHostMsg_FindInPageResultParams;
 struct AccessibilityHostMsg_LocationChangeParams;
 struct FrameHostMsg_DidFailProvisionalLoadWithError_Params;
 struct FrameHostMsg_OpenURL_Params;
-struct FrameHostMsg_BeginNavigation_Params;
-struct FrameMsg_Navigate_Params;
 #if defined(OS_MACOSX) || defined(OS_ANDROID)
 struct FrameHostMsg_ShowPopup_Params;
 #endif
@@ -66,12 +65,8 @@ class RenderWidgetHostView;
 class ResourceRequestBody;
 class StreamHandle;
 class TimeoutMonitor;
-struct BeginNavigationParams;
-struct CommitNavigationParams;
-struct CommonNavigationParams;
 struct ContextMenuParams;
 struct GlobalRequestID;
-struct HistoryNavigationParams;
 struct Referrer;
 struct ResourceResponse;
 struct TransitionLayerData;
@@ -301,7 +296,10 @@ class CONTENT_EXPORT RenderFrameHostImpl
   // If a cross-site request is in progress, we may be suspended while waiting
   // for the onbeforeunload handler, so this function might buffer the message
   // rather than sending it.
-  void Navigate(const FrameMsg_Navigate_Params& params);
+  void Navigate(const CommonNavigationParams& common_params,

[nasko, 2015/03/11 13:59:00]

Is there a specific reason this doesn't take the NavigationParams struct?

[clamy, 2015/03/11 16:50:07]

No, however this makes the logic in the function a bit less readable, since
instead of commit_params.url we have to call
navigation_params.commit_params.url.

+                const StartNavigationParams& start_params,
+                const CommitNavigationParams& commit_params,
+                const HistoryNavigationParams& history_params);
 
   // Load the specified URL; this is a shortcut for Navigate().
   void NavigateToURL(const GURL& url);
@@ -630,12 +628,13 @@ class CONTENT_EXPORT RenderFrameHostImpl
   // RenderFrameHost.
   bool navigations_suspended_;
 
-  // We only buffer the params for a suspended navigation while this RFH is the
-  // pending RenderFrameHost of a RenderFrameHostManager. There will only ever
-  // be one suspended navigation, because RenderFrameHostManager will destroy
-  // the pending RenderFrameHost and create a new one if a second navigation
-  // occurs.
-  scoped_ptr<FrameMsg_Navigate_Params> suspended_nav_params_;
+  // Holds the parameters for a suspended navigation. This can only happen while
+  // this RFH is the pending RenderFrameHost of a RenderFrameHostManager. There
+  // will only ever be one suspended navigation, because RenderFrameHostManager
+  // will destroy the pending RenderFrameHost and create a new one if a second
+  // navigation occurs.
+  // PlzNavigate: unused as navigations are never suspended.
+  scoped_ptr<NavigationParams> suspended_nav_params_;
 
   // When the last BeforeUnload message was sent.
   base::TimeTicks send_before_unload_start_time_;