Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Unified Diff: content/renderer/render_view_impl.h

Issue 971653004: Remove the FrameMsg_Navigate_Params (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@history-params
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index b5bbee0cf84aa2ab09c90efeff03219a38a28818..a7b3641ca0b71f90dca2232c54e118a69b18ff0e 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -840,8 +840,12 @@ class CONTENT_EXPORT RenderViewImpl
// the WebDataSource::ExtraData attribute. We use pending_navigation_state_
// as a temporary holder for the state until the WebDataSource corresponding
// to the new navigation is created. See DidCreateDataSource.
+ // PlzNavigate: |pending_start_params_| is not used.
// TODO(nasko): Move to RenderFrame, as this is per-frame state.
- scoped_ptr<FrameMsg_Navigate_Params> pending_navigation_params_;
+ scoped_ptr<CommonNavigationParams> pending_common_params_;
clamy 2015/03/09 14:34:47 Unlike in RenderFrameHostImpl, I did not bundle th
nasko 2015/03/09 23:24:23 Unifying those together will be nice, as we don't
clamy 2015/03/10 16:45:44 Done.
+ scoped_ptr<StartNavigationParams> pending_start_params_;
+ scoped_ptr<CommitNavigationParams> pending_commit_params_;
+ scoped_ptr<HistoryNavigationParams> pending_history_params_;
// Timer used to delay the updating of nav state (see SyncNavigationState).
base::OneShotTimer<RenderViewImpl> nav_state_sync_timer_;

Powered by Google App Engine
This is Rietveld 408576698