Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: content/renderer/accessibility/renderer_accessibility_browsertest.cc

Issue 971653004: Remove the FrameMsg_Navigate_Params (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@history-params
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/accessibility/renderer_accessibility_browsertest.cc
diff --git a/content/renderer/accessibility/renderer_accessibility_browsertest.cc b/content/renderer/accessibility/renderer_accessibility_browsertest.cc
index 4a6f5570889c2e63bf04c85337788deefcf2ae3f..980663312888f12e308d1807ec96a6d289d96170 100644
--- a/content/renderer/accessibility/renderer_accessibility_browsertest.cc
+++ b/content/renderer/accessibility/renderer_accessibility_browsertest.cc
@@ -189,17 +189,20 @@ TEST_F(RendererAccessibilityTest,
// message that was queued up before will be quickly discarded
// because the element it was referring to no longer exists,
// so the event here is from loading this new page.
- FrameMsg_Navigate_Params nav_params;
- nav_params.common_params.url = GURL("data:text/html,<p>Hello, again.</p>");
- nav_params.common_params.navigation_type = FrameMsg_Navigate_Type::NORMAL;
- nav_params.common_params.transition = ui::PAGE_TRANSITION_TYPED;
- nav_params.history_params.current_history_list_length = 1;
- nav_params.history_params.current_history_list_offset = 0;
- nav_params.history_params.pending_history_list_offset = 1;
- nav_params.history_params.page_id = -1;
- nav_params.commit_params.browser_navigation_start =
+ CommonNavigationParams common_params;
+ CommitNavigationParams commit_params;
+ HistoryNavigationParams history_params;
+ common_params.url = GURL("data:text/html,<p>Hello, again.</p>");
+ common_params.navigation_type = FrameMsg_Navigate_Type::NORMAL;
+ common_params.transition = ui::PAGE_TRANSITION_TYPED;
+ history_params.current_history_list_length = 1;
+ history_params.current_history_list_offset = 0;
+ history_params.pending_history_list_offset = 1;
+ history_params.page_id = -1;
+ commit_params.browser_navigation_start =
base::TimeTicks::FromInternalValue(1);
- frame()->OnNavigate(nav_params);
+ frame()->OnNavigate(common_params, StartNavigationParams(), commit_params,
+ history_params);
accessibility->SendPendingAccessibilityEvents();
EXPECT_TRUE(sink_->GetUniqueMessageMatching(
AccessibilityHostMsg_Events::ID));

Powered by Google App Engine
This is Rietveld 408576698