Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: content/browser/frame_host/navigation_entry_impl.h

Issue 971653004: Remove the FrameMsg_Navigate_Params (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@history-params
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_entry_impl.h
diff --git a/content/browser/frame_host/navigation_entry_impl.h b/content/browser/frame_host/navigation_entry_impl.h
index c69c978e0f416b60dab1fb6b7e9d9d307f56f8e9..a68a701191f5fba551b4ec4bbfaf927c55bf67b7 100644
--- a/content/browser/frame_host/navigation_entry_impl.h
+++ b/content/browser/frame_host/navigation_entry_impl.h
@@ -10,6 +10,7 @@
#include "base/time/time.h"
#include "content/browser/frame_host/frame_navigation_entry.h"
#include "content/browser/site_instance_impl.h"
+#include "content/common/frame_message_enums.h"
#include "content/public/browser/favicon_status.h"
#include "content/public/browser/global_request_id.h"
#include "content/public/browser/navigation_entry.h"
@@ -17,6 +18,11 @@
#include "content/public/common/ssl_status.h"
namespace content {
+class NavigationControllerImpl;
+struct CommitNavigationParams;
+struct CommonNavigationParams;
+struct HistoryNavigationParams;
+struct StartNavigationParams;
class CONTENT_EXPORT NavigationEntryImpl
: public NON_EXPORTED_BASE(NavigationEntry) {
@@ -228,6 +234,14 @@ class CONTENT_EXPORT NavigationEntryImpl
// Returns the history URL for a data URL to use in Blink.
GURL GetHistoryURLForDataURL() const;
+ CommonNavigationParams MakeCommonNavigationParams(
nasko 2015/03/09 23:24:23 minor nit: s/make/construct/. It is a bit longer,
clamy 2015/03/10 16:45:44 Done.
+ FrameMsg_Navigate_Type::Value navigation_type) const;
+ CommitNavigationParams MakeCommitNavigationParams(
+ base::TimeTicks navigation_start) const;
+ HistoryNavigationParams MakeHistoryNavigationParams(
+ NavigationControllerImpl* controller) const;
+ StartNavigationParams MakeStartNavigationParams() const;
+
#if defined(OS_ANDROID)
base::TimeTicks intent_received_timestamp() const {
return intent_received_timestamp_;

Powered by Google App Engine
This is Rietveld 408576698