Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Side by Side Diff: content/renderer/accessibility/renderer_accessibility_browsertest.cc

Issue 971653004: Remove the FrameMsg_Navigate_Params (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@history-params
Patch Set: Addressed Nasko's comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/utf_string_conversions.h" 5 #include "base/strings/utf_string_conversions.h"
6 #include "base/time/time.h" 6 #include "base/time/time.h"
7 #include "content/common/frame_messages.h" 7 #include "content/common/frame_messages.h"
8 #include "content/common/view_message_enums.h" 8 #include "content/common/view_message_enums.h"
9 #include "content/public/test/render_view_test.h" 9 #include "content/public/test/render_view_test.h"
10 #include "content/renderer/accessibility/renderer_accessibility.h" 10 #include "content/renderer/accessibility/renderer_accessibility.h"
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 content::FrameReplicationState()); 182 content::FrameReplicationState());
183 accessibility->SendPendingAccessibilityEvents(); 183 accessibility->SendPendingAccessibilityEvents();
184 EXPECT_FALSE(sink_->GetUniqueMessageMatching( 184 EXPECT_FALSE(sink_->GetUniqueMessageMatching(
185 AccessibilityHostMsg_Events::ID)); 185 AccessibilityHostMsg_Events::ID));
186 186
187 // Navigate, so we're not swapped out anymore. Now we should 187 // Navigate, so we're not swapped out anymore. Now we should
188 // send accessibility events again. Note that the 188 // send accessibility events again. Note that the
189 // message that was queued up before will be quickly discarded 189 // message that was queued up before will be quickly discarded
190 // because the element it was referring to no longer exists, 190 // because the element it was referring to no longer exists,
191 // so the event here is from loading this new page. 191 // so the event here is from loading this new page.
192 FrameMsg_Navigate_Params nav_params; 192 CommonNavigationParams common_params;
193 nav_params.common_params.url = GURL("data:text/html,<p>Hello, again.</p>"); 193 HistoryNavigationParams history_params;
194 nav_params.common_params.navigation_type = FrameMsg_Navigate_Type::NORMAL; 194 common_params.url = GURL("data:text/html,<p>Hello, again.</p>");
195 nav_params.common_params.transition = ui::PAGE_TRANSITION_TYPED; 195 common_params.navigation_type = FrameMsg_Navigate_Type::NORMAL;
196 nav_params.history_params.current_history_list_length = 1; 196 common_params.transition = ui::PAGE_TRANSITION_TYPED;
197 nav_params.history_params.current_history_list_offset = 0; 197 history_params.current_history_list_length = 1;
198 nav_params.history_params.pending_history_list_offset = 1; 198 history_params.current_history_list_offset = 0;
199 nav_params.history_params.page_id = -1; 199 history_params.pending_history_list_offset = 1;
200 nav_params.commit_params.browser_navigation_start = 200 history_params.page_id = -1;
201 base::TimeTicks::FromInternalValue(1); 201 frame()->OnNavigate(common_params, StartNavigationParams(),
202 frame()->OnNavigate(nav_params); 202 CommitNavigationParams(), history_params);
203 accessibility->SendPendingAccessibilityEvents(); 203 accessibility->SendPendingAccessibilityEvents();
204 EXPECT_TRUE(sink_->GetUniqueMessageMatching( 204 EXPECT_TRUE(sink_->GetUniqueMessageMatching(
205 AccessibilityHostMsg_Events::ID)); 205 AccessibilityHostMsg_Events::ID));
206 } 206 }
207 207
208 TEST_F(RendererAccessibilityTest, HideAccessibilityObject) { 208 TEST_F(RendererAccessibilityTest, HideAccessibilityObject) {
209 // Test RendererAccessibility and make sure it sends the 209 // Test RendererAccessibility and make sure it sends the
210 // proper event to the browser when an object in the tree 210 // proper event to the browser when an object in the tree
211 // is hidden, but its children are not. 211 // is hidden, but its children are not.
212 std::string html = 212 std::string html =
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 404
405 const IPC::Message* message = 405 const IPC::Message* message =
406 sink_->GetUniqueMessageMatching(AccessibilityHostMsg_Events::ID); 406 sink_->GetUniqueMessageMatching(AccessibilityHostMsg_Events::ID);
407 ASSERT_TRUE(message); 407 ASSERT_TRUE(message);
408 Tuple<std::vector<AccessibilityHostMsg_EventParams>, int> param; 408 Tuple<std::vector<AccessibilityHostMsg_EventParams>, int> param;
409 AccessibilityHostMsg_Events::Read(message, &param); 409 AccessibilityHostMsg_Events::Read(message, &param);
410 ASSERT_EQ(0U, get<0>(param).size()); 410 ASSERT_EQ(0U, get<0>(param).size());
411 } 411 }
412 412
413 } // namespace content 413 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698