Remove the FrameMsg_Navigate_Params

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 2102 matching lines @@
                           &ssl_status.signed_certificate_timestamp_ids);
   return ssl_status;
 }
 
 const std::string& RenderViewImpl::GetAcceptLanguages() const {
   return renderer_preferences_.accept_languages;
 }
 
 void RenderViewImpl::didCreateDataSource(WebLocalFrame* frame,
                                          WebDataSource* ds) {
-  bool content_initiated = !pending_navigation_params_.get();
+  bool content_initiated = !pending_common_params_.get();
+  bool browser_side_navigation_enabled =
+      base::CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kEnableBrowserSideNavigation);
+  CHECK(content_initiated || pending_commit_params_.get());
+  CHECK(content_initiated || pending_history_params_.get());
+  CHECK(content_initiated || pending_start_params_.get() ||
+        browser_side_navigation_enabled);
 
   // Make sure any previous redirect URLs end up in our new data source.
-  if (pending_navigation_params_.get()) {
+  if (pending_commit_params_.get()) {
     for (std::vector<GURL>::const_iterator i =
-             pending_navigation_params_->redirects.begin();
-         i != pending_navigation_params_->redirects.end(); ++i) {
+             pending_commit_params_->redirects.begin();
+         i != pending_commit_params_->redirects.end(); ++i) {
       ds->appendRedirect(*i);
     }
   }
 
   DocumentState* document_state = DocumentState::FromDataSource(ds);
   if (!document_state) {
     document_state = new DocumentState;
     ds->setExtraData(document_state);
     if (!content_initiated)
       PopulateDocumentStateFromPending(document_state);
@@ skipping 15 matching lines @@
     }
   }
 
   // The rest of RenderView assumes that a WebDataSource will always have a
   // non-null NavigationState.
   if (content_initiated) {
     document_state->set_navigation_state(
         NavigationState::CreateContentInitiated());
   } else {
     document_state->set_navigation_state(CreateNavigationStateFromPending());
-    pending_navigation_params_.reset();
+    pending_common_params_.reset();
+    pending_start_params_.reset();
+    pending_commit_params_.reset();
+    pending_history_params_.reset();
   }
 
   // DocumentState::referred_by_prefetcher_ is true if we are
   // navigating from a page that used prefetching using a link on that
   // page.  We are early enough in the request process here that we
   // can still see the DocumentState of the previous page and set
   // this value appropriately.
   // TODO(gavinp): catch the important case of navigation in a new
   // renderer process.
   if (webview()) {
@@ skipping 36 matching lines @@
         NOTREACHED();
     }
   }
 
   FOR_EACH_OBSERVER(
       RenderViewObserver, observers_, DidCreateDataSource(frame, ds));
 }
 
 void RenderViewImpl::PopulateDocumentStateFromPending(
     DocumentState* document_state) {
-  const FrameMsg_Navigate_Params& params = *pending_navigation_params_.get();
-  document_state->set_request_time(params.request_time);
+  document_state->set_request_time(pending_commit_params_->request_time);
 
   InternalDocumentStateData* internal_data =
       InternalDocumentStateData::FromDocumentState(document_state);
 
-  if (!params.common_params.url.SchemeIs(url::kJavaScriptScheme) &&
-      params.common_params.navigation_type == FrameMsg_Navigate_Type::RESTORE) {
+  if (!pending_common_params_->url.SchemeIs(url::kJavaScriptScheme) &&
+      pending_common_params_->navigation_type ==
+          FrameMsg_Navigate_Type::RESTORE) {
     // We're doing a load of a page that was restored from the last session. By
     // default this prefers the cache over loading (LOAD_PREFERRING_CACHE) which
     // can result in stale data for pages that are set to expire. We explicitly
     // override that by setting the policy here so that as necessary we load
     // from the network.
     //
     // TODO(davidben): Remove this in favor of passing a cache policy to the
     // loadHistoryItem call in OnNavigate. That requires not overloading
     // UseProtocolCachePolicy to mean both "normal load" and "determine cache
     // policy based on load type, etc".
     internal_data->set_cache_policy_override(
         WebURLRequest::UseProtocolCachePolicy);
   }
 
-  if (IsReload(params.common_params.navigation_type))
+  if (IsReload(pending_common_params_->navigation_type))
     document_state->set_load_type(DocumentState::RELOAD);
-  else if (params.history_params.page_state.IsValid())
+  else if (pending_history_params_->page_state.IsValid())
     document_state->set_load_type(DocumentState::HISTORY_LOAD);
   else
     document_state->set_load_type(DocumentState::NORMAL_LOAD);
 
   internal_data->set_is_overriding_user_agent(
-      params.commit_params.is_overriding_user_agent);
+      pending_commit_params_->is_overriding_user_agent);
   internal_data->set_must_reset_scroll_and_scale_state(
-      params.common_params.navigation_type ==
+      pending_common_params_->navigation_type ==
       FrameMsg_Navigate_Type::RELOAD_ORIGINAL_REQUEST_URL);
-  document_state->set_can_load_local_resources(params.can_load_local_resources);
+  document_state->set_can_load_local_resources(
+      pending_commit_params_->can_load_local_resources);
 }
 
 NavigationState* RenderViewImpl::CreateNavigationStateFromPending() {
-  const FrameMsg_Navigate_Params& params = *pending_navigation_params_.get();
   NavigationState* navigation_state = NULL;
 
   // A navigation resulting from loading a javascript URL should not be treated
   // as a browser initiated event.  Instead, we want it to look as if the page
   // initiated any load resulting from JS execution.
-  if (!params.common_params.url.SchemeIs(url::kJavaScriptScheme)) {
+  if (!pending_common_params_->url.SchemeIs(url::kJavaScriptScheme)) {
     navigation_state = NavigationState::CreateBrowserInitiated(

[clamy, 2015/03/09 14:34:47]

As explained in render_frame_impl.cc, the next goal is to have NavigationState
take ownership of the pending HistoryNavigationParams and StartNavigationParams
here, which should make this cleaner.

-        params.history_params.page_id,
-        params.history_params.pending_history_list_offset,
-        params.history_params.should_clear_history_list,
-        params.common_params.transition);
-    navigation_state->set_should_replace_current_entry(
-        params.should_replace_current_entry);
-    navigation_state->set_transferred_request_child_id(
-        params.transferred_request_child_id);
-    navigation_state->set_transferred_request_request_id(
-        params.transferred_request_request_id);
-    navigation_state->set_allow_download(params.common_params.allow_download);
-    navigation_state->set_extra_headers(params.extra_headers);
+        pending_history_params_->page_id,
+        pending_history_params_->pending_history_list_offset,
+        pending_history_params_->should_clear_history_list,
+        pending_common_params_->transition);
+    navigation_state->set_allow_download(
+        pending_common_params_->allow_download);
+    if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+            switches::kEnableBrowserSideNavigation)) {
+      navigation_state->set_should_replace_current_entry(
+          pending_start_params_->should_replace_current_entry);
+      navigation_state->set_transferred_request_child_id(
+          pending_start_params_->transferred_request_child_id);
+      navigation_state->set_transferred_request_request_id(
+          pending_start_params_->transferred_request_request_id);
+      navigation_state->set_extra_headers(pending_start_params_->extra_headers);
+    }
   } else {
     navigation_state = NavigationState::CreateContentInitiated();
   }
   return navigation_state;
 }
 
 void RenderViewImpl::didChangeIcon(WebLocalFrame* frame,
                                    WebIconURL::Type icon_type) {
   if (frame->parent())
     return;
@@ skipping 1707 matching lines @@
     std::vector<gfx::Size> sizes;
     ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes);
     if (!url.isEmpty())
       urls.push_back(
           FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes));
   }
   SendUpdateFaviconURL(urls);
 }
 
 }  // namespace content