Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js

Issue 971653003: Files.app: Extract cache part from NewMetadataProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix audio player. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js
diff --git a/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js b/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js
index f6cc00726d65620aa07d7afc59a3ce9b4baf58ef..2610720531d889f4b54e7801793e2cf113959064 100644
--- a/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js
+++ b/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js
@@ -6,14 +6,12 @@
* Metadata provider for FileEntry#getMetadata.
* TODO(hirono): Rename thumbnailUrl with externalThumbnailUrl.
*
- * @param {!MetadataProviderCache} cache
* @constructor
* @extends {NewMetadataProvider}
* @struct
*/
-function ExternalMetadataProvider(cache) {
- NewMetadataProvider.call(
- this, cache, ExternalMetadataProvider.PROPERTY_NAMES);
+function ExternalMetadataProvider() {
+ NewMetadataProvider.call(this, ExternalMetadataProvider.PROPERTY_NAMES);
}
/**
@@ -44,7 +42,9 @@ ExternalMetadataProvider.prototype.__proto__ = NewMetadataProvider.prototype;
/**
* @override
*/
-ExternalMetadataProvider.prototype.getImpl = function(requests) {
+ExternalMetadataProvider.prototype.get = function(requests) {
+ if (!requests.length)
+ return Promise.resolve([]);
return new Promise(function(fulfill) {
var urls = [];
for (var i = 0; i < requests.length; i++) {

Powered by Google App Engine
This is Rietveld 408576698