Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js

Issue 971653003: Files.app: Extract cache part from NewMetadataProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix audio player. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js
diff --git a/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js b/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js
index d245b95ee9636e530c634e0417633b8adcbf3929..b263a90f8099516d7fc454b4fbd8a6e1de501e58 100644
--- a/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js
+++ b/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js
@@ -3,17 +3,15 @@
// found in the LICENSE file.
/**
- * @param {!MetadataProviderCache} cache
* @param {!MessagePort=} opt_messagePort Message port overriding the default
* worker port.
* @extends {NewMetadataProvider}
* @constructor
* @struct
*/
-function ContentMetadataProvider(cache, opt_messagePort) {
+function ContentMetadataProvider(opt_messagePort) {
NewMetadataProvider.call(
this,
- cache,
ContentMetadataProvider.PROPERTY_NAMES);
/**
@@ -96,11 +94,14 @@ ContentMetadataProvider.prototype.__proto__ = NewMetadataProvider.prototype;
/**
* @override
*/
-ContentMetadataProvider.prototype.getImpl = function(requests) {
+ContentMetadataProvider.prototype.get = function(requests) {
+ if (!requests.length)
+ return Promise.resolve([]);
+
var promises = [];
for (var i = 0; i < requests.length; i++) {
promises.push(new Promise(function(request, fulfill) {
- this.fetch(request.entry, request.names, fulfill);
+ this.getImpl_(request.entry, request.names, fulfill);
}.bind(this, requests[i])));
}
return Promise.all(promises);
@@ -112,8 +113,9 @@ ContentMetadataProvider.prototype.getImpl = function(requests) {
* @param {!Array<string>} names Requested metadata type.
* @param {function(Object)} callback Callback expects a map from metadata type
* to metadata value. This callback is called asynchronously.
+ * @private
*/
-ContentMetadataProvider.prototype.fetch = function(entry, names, callback) {
+ContentMetadataProvider.prototype.getImpl_ = function(entry, names, callback) {
if (entry.isDirectory) {
setTimeout(callback.bind(null, {}), 0);
return;

Powered by Google App Engine
This is Rietveld 408576698