Issue 971653002: Revert of add compose-colorfilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 971653002: Revert of add compose-colorfilter (Closed)

Created:
5 years, 9 months ago by reed2

Modified:
5 years, 9 months ago

Reviewers:
f(malita), bsalomon, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of add compose-colorfilter (patchset #2 id:20001 of https://codereview.chromium.org/969673002/) Reason for revert: need to register subclass for serialization Original issue's description: > add compose-colorfilter > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/b675a73c1f3f4a433c4893199a0bd11126dfe130 TBR=fmalita@chromium.org,bsalomon@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/5bd055c0386499f2dc8c66173a7534b75af602bf

Created: 5 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -165 lines)			Patch
M	gm/tablecolorfilter.cpp	View	3 chunks	+20 lines, -85 lines	0 comments	Download
M	include/core/SkColorFilter.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/core/SkColorFilter.cpp	View	2 chunks	+4 lines, -74 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971653002/1

5 years, 9 months ago (2015-03-02 03:16:30 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-02 03:16:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5bd055c0386499f2dc8c66173a7534b75af602bf