Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 971633002: Revert the 'gn_migration.gypi' patches. (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, jam, sky, tfarina, smut
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert the 'gn_migration.gypi' patches. It looks like these patches might be confusing the analyze step on the ios bots. I don't understand the errors I'm seeing on them, but they seem to have started when the first of these patches landed, so I'm going to try reverting them and see what happens. This reverts: "Rework how the gn migration targets are included from all.gyp." commit 91cb1747a84d80acc9fc5045c971986f1799e02b (#318599). "Fix a build failing in the x86 linux builds ..." commit 425ba073036f96f04aea09c9836826ccb2e124e4. (#318626) "Fix nacl-only targets in gn_migration.gypi" commit ad333257fe8e7d9b632f728de5fe6db9feb9a64d. (#318631) TBR=brettw@chromium.org BUG=461019 NOTRY=true Committed: https://crrev.com/378e940e74d07896695b6bd1582de760bab7c3b1 Cr-Commit-Position: refs/heads/master@{#318636}

Patch Set 1 #

Patch Set 2 : merge to #318635 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -508 lines) Patch
M build/all.gyp View 2 chunks +150 lines, -6 lines 0 comments Download
D build/gn_migration.gypi View 1 1 chunk +0 lines, -502 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Dirk Pranke
I don't understand why this set of patches seems to still be causing problems on ...
5 years, 9 months ago (2015-03-01 23:32:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971633002/1
5 years, 9 months ago (2015-03-01 23:32:54 UTC) #3
Dirk Pranke
Here's a link to the waterfall w/ builds 844 and 843 failing: http://build.chromium.org/p/tryserver.chromium.mac/waterfall?last_time=1425101800 Here's a ...
5 years, 9 months ago (2015-03-01 23:38:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971633002/20001
5 years, 9 months ago (2015-03-02 01:39:23 UTC) #6
Dirk Pranke
Setting NOTRY=true because I *think* the mac failures are goma-related, and not due to my ...
5 years, 9 months ago (2015-03-02 01:39:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-02 01:39:45 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 01:40:23 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/378e940e74d07896695b6bd1582de760bab7c3b1
Cr-Commit-Position: refs/heads/master@{#318636}

Powered by Google App Engine
This is Rietveld 408576698