Issue 971623003: [Skia] Add SK_API to SkParse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 971623003: [Skia] Add SK_API to SkParse. (Closed)

Created:
5 years, 9 months ago by huangs

Modified:
5 years, 9 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

[Skia] Add SK_API to SkParse. For https://codereview.chromium.org/924063003/ , we would like to use the SkParse::FindColor(). Adding SK_API to SkParse is necessary for component build to work. BUG=skia: Committed: https://skia.googlesource.com/skia/+/9345eef3a052b6f7d41b1e2ab7dd075682188ffa

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	include/utils/SkParse.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

huangs

PTAL. I'm not sure if I should add SK_API elsewhere as well. Thanks!

5 years, 9 months ago (2015-03-01 23:09:43 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971623003/1

5 years, 9 months ago (2015-03-02 15:45:41 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-02 15:51:21 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9345eef3a052b6f7d41b1e2ab7dd075682188ffa