Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 971573002: Sync the MutationObserver and MutationRecord interfaces with the spec (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the MutationObserver and MutationRecord interfaces with the spec Making previousSibling and nextSibling nullable does not change the generated code. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M Source/core/dom/MutationObserver.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/dom/MutationRecord.idl View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
5 years, 9 months ago (2015-03-01 15:23:29 UTC) #2
Jens Widell
LGTM
5 years, 9 months ago (2015-03-01 15:25:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971573002/1
5 years, 9 months ago (2015-03-01 15:26:24 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-01 17:15:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191058

Powered by Google App Engine
This is Rietveld 408576698