Issue 971443003: Revert of Make sure the --site-per-process flag is present for subframe process swaps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 971443003: Revert of Make sure the --site-per-process flag is present for subframe process swaps. (Closed)

Created:
5 years, 9 months ago by Nico

Modified:
5 years, 9 months ago

Reviewers:
Charlie Reis, alexmos

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Make sure the --site-per-process flag is present for subframe process swaps. (patchset #3 id:40001 of https://codereview.chromium.org/959303003/) Reason for revert: Somewhat speculative; looks like this might have turned the asan/win bot red. (See comment #17 on the review for links / stack.) Original issue's description: > Make sure the --site-per-process flag is present for subframe process swaps. > > BUG=461494 > TEST=Crash report should show that --site-per-process flag is present. > > Committed: https://crrev.com/159d8ae5ad6c2b45a3c891cef89fe15cdaf46b5e > Cr-Commit-Position: refs/heads/master@{#318558} TBR=alexmos@chromium.org,creis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=461494 Committed: https://crrev.com/0612babb1b1ed350979e2ef3d8c099b36021c744 Cr-Commit-Position: refs/heads/master@{#318609}

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	content/browser/loader/cross_site_resource_handler.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

Nico

Created Revert of Make sure the --site-per-process flag is present for subframe process swaps.

5 years, 9 months ago (2015-02-28 21:01:28 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971443003/1

5 years, 9 months ago (2015-02-28 21:01:33 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-02-28 21:03:07 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0612babb1b1ed350979e2ef3d8c099b36021c744
Cr-Commit-Position: refs/heads/master@{#318609}