Issue 971433002: Revert of Test PostMessage to popup window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 971433002: Revert of Test PostMessage to popup window (Closed)

Created:
5 years, 9 months ago by hush (inactive)

Modified:
5 years, 9 months ago

Reviewers:
sgurun-gerrit only

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Test PostMessage to popup window (patchset #7 id:110001 of https://codereview.chromium.org/964753002/) Reason for revert: This landed soon after https://crrev.com/65b9392697befefd009dbe73d75dfe66894d814c which changed the signature of setWebEventHandler As a result, it broke the linux build bot. http://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/10739 Original issue's description: > Test PostMessage to popup window > > BUG=460998 > > Committed: https://crrev.com/51c1620185396384cfe6e2f4e3359e57c6431600 > Cr-Commit-Position: refs/heads/master@{#318591} TBR=sgurun@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460998 Committed: https://crrev.com/f3b2cc7f6cd363a422e6eb7c8858c4be160109ed Cr-Commit-Position: refs/heads/master@{#318592}

Created: 5 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -153 lines)			Patch
M	android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java	View	2 chunks	+0 lines, -57 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java	View	3 chunks	+62 lines, -10 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java	View	1 chunk	+0 lines, -86 lines	0 comments	Download

Total messages: 4 (0 generated)

hush (inactive)

Created Revert of Test PostMessage to popup window

5 years, 9 months ago (2015-02-28 04:28:35 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971433002/1

5 years, 9 months ago (2015-02-28 04:28:56 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-02-28 04:30:36 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f3b2cc7f6cd363a422e6eb7c8858c4be160109ed
Cr-Commit-Position: refs/heads/master@{#318592}