chrome/browser/supervised_user/child_accounts/child_account_status_observer.h - Issue 971383002: Removing FRE UI for unicorn accounts.

Side by Side Diff: chrome/browser/supervised_user/child_accounts/child_account_status_observer.h

Issue 971383002: Removing FRE UI for unicorn accounts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean-up. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/supervised_user/child_accounts/child_account_service.h ('K') | « chrome/browser/supervised_user/child_accounts/child_account_service.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_SUPERVISED_USER_CHILD_ACCOUNTS_CHILD_ACCOUNT_SERVICE_ANDR OID_H_	5 #ifndef CHROME_BROWSER_SUPERVISED_USER_CHILD_ACCOUNTS_CHILD_ACCOUNT_STATUS_OBSER VER_H_

6 #define CHROME_BROWSER_SUPERVISED_USER_CHILD_ACCOUNTS_CHILD_ACCOUNT_SERVICE_ANDR OID_H_	6 #define CHROME_BROWSER_SUPERVISED_USER_CHILD_ACCOUNTS_CHILD_ACCOUNT_STATUS_OBSER VER_H_

7	7

8 #include <jni.h>	8 class ChildAccountStatusObserver {

	9 public:
	Bernhard Bauer 2015/03/10 09:55:12 "public:" is indented one space, then the method d "public:" is indented one space, then the method declarations are indented two spaces (i.e. one more than the previous line). merkulova 2015/03/10 11:53:57 Acknowledged. Show quoted text On 2015/03/10 09:55:12, Bernhard Bauer wrote: > "public:" is indented one space, then the method declarations are indented two > spaces (i.e. one more than the previous line). Acknowledged.
	10 // Observes changes from Unknown to other states.

	11 virtual void OnChildAccountStatusChanged(bool is_child) {}
	Bernhard Bauer 2015/03/10 09:55:12 If this is only called when transitioning from unk If this is only called when transitioning from unknown state to known state, maybe reflect that in the name (right now it looks like this method is called on any state change). Also, are you planning to add more methods to this interface? If not, consider using a base::Callback instead. Marc Treib 2015/03/10 10:43:34 I think it should be called on any state change, o Show quoted text On 2015/03/10 09:55:12, Bernhard Bauer wrote: > If this is only called when transitioning from unknown state to known state, > maybe reflect that in the name (right now it looks like this method is called on > any state change). I think it should be called on any state change, otherwise there's really no need for an Observer interface. Show quoted text > Also, are you planning to add more methods to this interface? If not, consider > using a base::Callback instead. Hm, I guess that's the alternative: A callback that's called exactly once, when we get the child state for the first time. merkulova 2015/03/10 11:53:57 Removed the class completely. Show quoted text On 2015/03/10 10:43:34, Marc Treib wrote: > On 2015/03/10 09:55:12, Bernhard Bauer wrote: > > If this is only called when transitioning from unknown state to known state, > > maybe reflect that in the name (right now it looks like this method is called > on > > any state change). > > I think it should be called on any state change, otherwise there's really no > need for an Observer interface. > > > Also, are you planning to add more methods to this interface? If not, consider > > using a base::Callback instead. > > Hm, I guess that's the alternative: A callback that's called exactly once, when > we get the child state for the first time. Removed the class completely.
	12 };

9	13

10 // Register native methods	14 #endif // CHROME_BROWSER_SUPERVISED_USER_CHILD_ACCOUNTS_CHILD_ACCOUNT_STATUS_OB SERVER_H_

11 bool RegisterChildAccountService(JNIEnv* env);

12

13 #endif // CHROME_BROWSER_SUPERVISED_USER_CHILD_ACCOUNTS_CHILD_ACCOUNT_SERVICE_A NDROID_H_

OLD	NEW