Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 971363002: Fixed Chrome OS component GN build. (Closed)

Created:
5 years, 9 months ago by dzhioev (left Google)
Modified:
5 years, 9 months ago
Reviewers:
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed Chrome OS component GN build. Component build was broken since 4a84927b, where chromeos::device_event_log was moved to components. TBR=reillyg@chromium.org,derat@chromium.org BUG=none Committed: https://crrev.com/f6ea156c11c4fd219b8d3b2e748f55ce4d636769 Cr-Commit-Position: refs/heads/master@{#318875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/chromeos/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971363002/1
5 years, 9 months ago (2015-03-03 14:38:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 15:10:22 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 15:11:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6ea156c11c4fd219b8d3b2e748f55ce4d636769
Cr-Commit-Position: refs/heads/master@{#318875}

Powered by Google App Engine
This is Rietveld 408576698