Index: chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js |
diff --git a/chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js b/chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js |
index b106b7635eafa572ef59f03e190f2d5b0780bab9..8b242ae8c505eae5d1cd4d124cd2c9de385b9310 100644 |
--- a/chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js |
+++ b/chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js |
@@ -25,11 +25,13 @@ function clobber(obj, name, qualifiedName) { |
// Clobbering constructors would break everything. |
// Clobbering toString is annoying. |
// Clobbering __proto__ breaks in ways that grep can't find. |
+ // Function name property is configurable. |
not at google - send to devlin
2015/03/03 17:27:19
Instead, comment:
// Clobbering Function.name wil
|
// Clobbering Function.call would make it impossible to implement these tests. |
// Clobbering Object.valueOf breaks v8. |
if (name == 'constructor' || |
name == 'toString' || |
name == '__proto__' || |
+ name == 'name' || |
not at google - send to devlin
2015/03/03 17:27:19
Prefer:
qualifiedName == 'Function.name'
arv (Not doing code reviews)
2015/03/03 17:36:34
That would not work. There are a bunch of other fu
|
qualifiedName == 'Function.call' || |
qualifiedName == 'Object.valueOf') { |
return; |