Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js

Issue 971343003: Extension test: Do not clobber function name property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js
diff --git a/chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js b/chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js
index b106b7635eafa572ef59f03e190f2d5b0780bab9..8b242ae8c505eae5d1cd4d124cd2c9de385b9310 100644
--- a/chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js
+++ b/chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js
@@ -25,11 +25,13 @@ function clobber(obj, name, qualifiedName) {
// Clobbering constructors would break everything.
// Clobbering toString is annoying.
// Clobbering __proto__ breaks in ways that grep can't find.
+ // Function name property is configurable.
not at google - send to devlin 2015/03/03 17:27:19 Instead, comment: // Clobbering Function.name wil
// Clobbering Function.call would make it impossible to implement these tests.
// Clobbering Object.valueOf breaks v8.
if (name == 'constructor' ||
name == 'toString' ||
name == '__proto__' ||
+ name == 'name' ||
not at google - send to devlin 2015/03/03 17:27:19 Prefer: qualifiedName == 'Function.name'
arv (Not doing code reviews) 2015/03/03 17:36:34 That would not work. There are a bunch of other fu
qualifiedName == 'Function.call' ||
qualifiedName == 'Object.valueOf') {
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698