Extension test: Do not clobber function name property

chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function() {
 
 // We are going to kill all of the builtins, so hold onto the ones we need.
 var defineGetter = Object.prototype.__defineGetter__;
 var defineSetter = Object.prototype.__defineSetter__;
 var Error = window.Error;
 var forEach = Array.prototype.forEach;
 var push = Array.prototype.push;
 var hasOwnProperty = Object.prototype.hasOwnProperty;
 var getOwnPropertyNames = Object.getOwnPropertyNames;
 var stringify = JSON.stringify;
 
 // Kill all of the builtins functions to give us a fairly high confidence that
 // the environment our bindings run in can't interfere with our code.
 // These are taken from the ECMAScript spec.
 var builtinTypes = [
   Object, Function, Array, String, Boolean, Number, Math, Date, RegExp, JSON,
 ];
 
 function clobber(obj, name, qualifiedName) {
   // Clobbering constructors would break everything.
   // Clobbering toString is annoying.
   // Clobbering __proto__ breaks in ways that grep can't find.
+  // Function name property is configurable.

[not at google - send to devlin, 2015/03/03 17:27:19]

Instead, comment:

// Clobbering Function.name will break because
// SafeBuiltins does not support getters yet. See crbug.com/463526.

   // Clobbering Function.call would make it impossible to implement these tests.
   // Clobbering Object.valueOf breaks v8.
   if (name == 'constructor' ||
       name == 'toString' ||
       name == '__proto__' ||
+      name == 'name' ||

[not at google - send to devlin, 2015/03/03 17:27:19]

Prefer:

qualifiedName == 'Function.name'

[arv (Not doing code reviews), 2015/03/03 17:36:34]

That would not work. There are a bunch of other functions that have names, for
example `Object.name` which is what caused the test failure but I assume this
test would reach String.name, RegExp.name etc efter that.

       qualifiedName == 'Function.call' ||
       qualifiedName == 'Object.valueOf') {
     return;
   }
   if (typeof(obj[name]) == 'function') {
     obj[name] = function() {
       throw new Error('Clobbered ' + qualifiedName + ' function');
     };
   } else {
     defineGetter.call(obj, name, function() {
@@ skipping 248 matching lines @@
     if (!message)
       message = kMessage;
 
     chrome.runtime.sendMessage(extensionId, message,
         {'includeTlsChannelId': includeTlsChannelId},
         checkTlsChannelIdResponse);
   }
 };
 
 }());