Extension test: Do not clobber function name property

Extension test: Do not clobber function name property

ES6 makes the function name property configurable, which
means that __defineGetter__ will add a getter and not
silently fail like before.

This change is in preparation of landing this feature in
V8.

BUG=463526
R=kalman@chromium.org

Committed: https://crrev.com/5f75a3be4c9334aba627d6c5eb884adf965e1d78
Cr-Commit-Position: refs/heads/master@{#318915}

[arv (Not doing code reviews), 2015-03-03 14:21:34]

PTAL

[not at google - send to devlin, 2015-03-03 17:27:19]

lgtm

Reference bug 463526 in the BUG field.

https://codereview.chromium.org/971343003/diff/1/chrome/test/data/extensions/...
File
chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js
(right):

https://codereview.chromium.org/971343003/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js:28:
// Function name property is configurable.
Instead, comment:

// Clobbering Function.name will break because
// SafeBuiltins does not support getters yet. See crbug.com/463526.

https://codereview.chromium.org/971343003/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js:34:
name == 'name' ||
Prefer:

qualifiedName == 'Function.name'

[arv (Not doing code reviews), 2015-03-03 17:34:39]

Update comment

[arv (Not doing code reviews), 2015-03-03 17:36:34]

https://codereview.chromium.org/971343003/diff/1/chrome/test/data/extensions/...
File
chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js
(right):

https://codereview.chromium.org/971343003/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js:34:
name == 'name' ||
On 2015/03/03 17:27:19, kalman wrote:
> Prefer:
> 
> qualifiedName == 'Function.name'

That would not work. There are a bunch of other functions that have names, for
example `Object.name` which is what caused the test failure but I assume this
test would reach String.name, RegExp.name etc efter that.

[arv (Not doing code reviews), 2015-03-03 17:37:20]

On 2015/03/03 17:36:34, arv wrote:
>
https://codereview.chromium.org/971343003/diff/1/chrome/test/data/extensions/...
> File
>
chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js
> (right):
> 
>
https://codereview.chromium.org/971343003/diff/1/chrome/test/data/extensions/...
>
chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js:34:
> name == 'name' ||
> On 2015/03/03 17:27:19, kalman wrote:
> > Prefer:
> > 
> > qualifiedName == 'Function.name'
> 
> That would not work. There are a bunch of other functions that have names, for
> example `Object.name` which is what caused the test failure but I assume this
> test would reach String.name, RegExp.name etc efter that.

What I could do is `typeof obj === 'function' && name === 'name'`.

[arv (Not doing code reviews), 2015-03-03 17:38:59]

Use typeof as well

[arv (Not doing code reviews), 2015-03-03 17:40:23]

update comment

[arv (Not doing code reviews), 2015-03-03 17:40:53]

PTAL

[not at google - send to devlin, 2015-03-03 17:42:53]

lgtm

[arv (Not doing code reviews), 2015-03-03 17:45:51]

The CQ bit was checked by arv@chromium.org

[arv (Not doing code reviews), 2015-03-03 17:46:08]

Thanks

[commit-bot: I haz the power, 2015-03-03 17:47:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/971343003/60001

[commit-bot: I haz the power, 2015-03-03 18:46:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-03 18:47:24]

Patchset 4 (id:??) landed as
https://crrev.com/5f75a3be4c9334aba627d6c5eb884adf965e1d78
Cr-Commit-Position: refs/heads/master@{#318915}