Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 971303003: Simplify file_system_provider::Queue. (Closed)

Created:
5 years, 9 months ago by mtomasz
Modified:
5 years, 9 months ago
Reviewers:
hirono
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify file_system_provider::Queue. IsAborted() and Remove() were removed, and semantics of Abort() simplified. TEST=unit_tests: *FileSystemProvider* BUG=463344 Committed: https://crrev.com/95a1ab38f32e1643b31fe3231f78e5d353529cd4 Cr-Commit-Position: refs/heads/master@{#319041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -224 lines) Patch
M chrome/browser/chromeos/file_system_provider/provided_file_system.cc View 8 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/queue.h View 3 chunks +12 lines, -32 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/queue.cc View 3 chunks +9 lines, -49 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/queue_unittest.cc View 8 chunks +5 lines, -125 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/throttled_file_system.cc View 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtomasz
@hirono: PTAL. Thanks.
5 years, 9 months ago (2015-03-04 06:56:09 UTC) #2
hirono
lgtm, thanks!
5 years, 9 months ago (2015-03-04 09:11:32 UTC) #3
mtomasz
Thanks!
5 years, 9 months ago (2015-03-04 09:19:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971303003/1
5 years, 9 months ago (2015-03-04 09:20:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 09:23:39 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 09:24:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95a1ab38f32e1643b31fe3231f78e5d353529cd4
Cr-Commit-Position: refs/heads/master@{#319041}

Powered by Google App Engine
This is Rietveld 408576698