Source/platform/heap/ThreadState.cpp - Issue 971283002: Add canExceedIdleDeadlineIfRequired function to Scheduler and use it in Oilpan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/ThreadState.cpp

Issue 971283002: Add canExceedIdleDeadlineIfRequired function to Scheduler and use it in Oilpan (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/heap/ThreadState.cpp

diff --git a/Source/platform/heap/ThreadState.cpp b/Source/platform/heap/ThreadState.cpp

index eb3e42f4b538d4a5ce9f0f4768e40a7beef34b72..87ef12487520341a20806d56365b1faf3b579feb 100644

--- a/Source/platform/heap/ThreadState.cpp

+++ b/Source/platform/heap/ThreadState.cpp

@@ -729,7 +729,7 @@ void ThreadState::performIdleGC(double deadlineSeconds)

return;

double idleDeltaInSeconds = deadlineSeconds - Platform::current()->monotonicallyIncreasingTime();

- if (idleDeltaInSeconds <= Heap::estimatedMarkingTime()) {

+ if (idleDeltaInSeconds <= Heap::estimatedMarkingTime() && !Scheduler::shared()->isMaximumIdleDeadline(deadlineSeconds)) {

haraken 2015/03/03 15:10:39 Shall we add a comment on what this branch is doin

rmcilroy 2015/03/17 10:33:30 Done.

scheduleIdleGC();

return;

}

« no previous file with comments | « no previous file | Source/platform/scheduler/Scheduler.h » ('j') | no next file with comments »