Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: build/android/lint/suppressions.xml

Issue 971223004: Fix up a few more lint warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/shell/res/drawable/progress_bar.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 25 matching lines...) Expand all
36 <ignore path="content/public/android/java/src/org/chromium/content/browser/P opupZoomer.java"/> 36 <ignore path="content/public/android/java/src/org/chromium/content/browser/P opupZoomer.java"/>
37 </issue> 37 </issue>
38 <issue id="ExportedContentProvider"> 38 <issue id="ExportedContentProvider">
39 <ignore path="AndroidManifest.xml"/> 39 <ignore path="AndroidManifest.xml"/>
40 </issue> 40 </issue>
41 <issue id="HandlerLeak"> 41 <issue id="HandlerLeak">
42 <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDe tector.java"/> 42 <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDe tector.java"/>
43 </issue> 43 </issue>
44 <issue id="IconDensities"> 44 <issue id="IconDensities">
45 <!-- crbug.com/457918 is tracking missing assets --> 45 <!-- crbug.com/457918 is tracking missing assets -->
46 <ignore path="components/web_contents_delegate_android/android/java/res/draw able-xxhdpi"/>
47 <ignore path="components/web_contents_delegate_android/android/java/res/draw able-xxxhdpi"/>
46 <ignore path="content/public/android/java/res/drawable-xxhdpi"/> 48 <ignore path="content/public/android/java/res/drawable-xxhdpi"/>
47 <ignore path="content/public/android/java/res/drawable-xxxhdpi"/> 49 <ignore path="content/public/android/java/res/drawable-xxxhdpi"/>
48 <ignore path="chrome/android/java/res/drawable-xxhdpi"/> 50 <ignore path="chrome/android/java/res/drawable-xxhdpi"/>
49 <ignore path="chrome/android/java/res/drawable-xxxhdpi"/> 51 <ignore path="chrome/android/java/res/drawable-xxxhdpi"/>
50 <ignore path="ui/android/java/res/drawable-xxhdpi"/> 52 <ignore path="ui/android/java/res/drawable-xxhdpi"/>
51 <ignore path="ui/android/java/res/drawable-xxxhdpi"/> 53 <ignore path="ui/android/java/res/drawable-xxxhdpi"/>
52 </issue> 54 </issue>
53 <!-- It is OK for content_shell_apk and chrome_shell_apk to have missing asset s. --> 55 <!-- It is OK for content_shell_apk and chrome_shell_apk to have missing asset s. -->
54 <issue id="IconLocation"> 56 <issue id="IconLocation">
55 <ignore path="content/shell/android/java/res/"/> 57 <ignore path="content/shell/android/java/res/"/>
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 <!-- These files are used by chrome_shell_apk and chrome_apk targets. --> 123 <!-- These files are used by chrome_shell_apk and chrome_apk targets. -->
122 <ignore path="chrome/android/java/res/layout/accessibility_tab_switcher.xml" /> 124 <ignore path="chrome/android/java/res/layout/accessibility_tab_switcher.xml" />
123 <ignore path="chrome/android/java/res/drawable/btn_back.xml" /> 125 <ignore path="chrome/android/java/res/drawable/btn_back.xml" />
124 <ignore path="chrome/android/java/res/drawable/btn_forward.xml" /> 126 <ignore path="chrome/android/java/res/drawable/btn_forward.xml" />
125 </issue> 127 </issue>
126 <issue id="SignatureOrSystemPermissions" severity="ignore"/> 128 <issue id="SignatureOrSystemPermissions" severity="ignore"/>
127 <issue id="UnusedAttribute" severity="ignore"/> 129 <issue id="UnusedAttribute" severity="ignore"/>
128 <issue id="ViewConstructor" severity="ignore"/> 130 <issue id="ViewConstructor" severity="ignore"/>
129 <issue id="WrongCall" severity="ignore"/> 131 <issue id="WrongCall" severity="ignore"/>
130 </lint> 132 </lint>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/shell/res/drawable/progress_bar.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698