Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 971223002: [turbofan] Fix ControlFlowOptimizer to also handle non-control nodes in the control chain. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix ControlFlowOptimizer to also handle non-control nodes in the control chain. Committed: https://crrev.com/8df194c14a1f702b34eb70eab1f2e0f838487d68 Cr-Commit-Position: refs/heads/master@{#26949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -20 lines) Patch
M src/compiler/control-flow-optimizer.cc View 2 chunks +15 lines, -15 lines 0 comments Download
M test/unittests/compiler/control-flow-optimizer-unittest.cc View 2 chunks +47 lines, -5 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-03-03 06:02:05 UTC) #2
Jarin
lgtm
5 years, 9 months ago (2015-03-03 06:09:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971223002/1
5 years, 9 months ago (2015-03-03 06:10:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 06:11:42 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 06:11:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8df194c14a1f702b34eb70eab1f2e0f838487d68
Cr-Commit-Position: refs/heads/master@{#26949}

Powered by Google App Engine
This is Rietveld 408576698