Gallery: Start to use new metadata model in Gallery.

Gallery: Start to use new metadata model in Gallery.

BUG=410766
TEST=None

Committed: https://crrev.com/e8c5cdc06121a4435816d626e5490fd8f5e9e9b3
Cr-Commit-Position: refs/heads/master@{#319039}

[hirono, 2015-03-03 03:35:51]

hirono@chromium.org changed reviewers:
+ yawano@chromium.org

[hirono, 2015-03-03 03:35:51]

PTAL, thanks!
Note that we renamed FileSystemMetadata with MetadataModel.
crrev.com/971723002

[yawano, 2015-03-03 04:14:50]

https://codereview.chromium.org/971173002/diff/40001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/gallery.js (right):

https://codereview.chromium.org/971173002/diff/40001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/gallery.js:385: function(metadataList) {
very small nit: We uses metadataList in this function with different meaning
(for different type of variable). How about to use metadataLists here?

https://codereview.chromium.org/971173002/diff/40001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/gallery_data_model.js (right):

https://codereview.chromium.org/971173002/diff/40001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/gallery_data_model.js:104: item.metadataItem_,
Is this item.metadataItem_ updated for the new file?

https://codereview.chromium.org/971173002/diff/40001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/971173002/diff/40001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/image_editor/image_util.js:521:
this.metadataModel_.get([entry], ['contentThumbnailTransform']).then(
Isn't this contentImageTransform instead of contentThumbnailTransform?

[hirono, 2015-03-04 05:07:04]

Thanks!

https://codereview.chromium.org/971173002/diff/40001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/gallery.js (right):

https://codereview.chromium.org/971173002/diff/40001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/gallery.js:385: function(metadataList) {
On 2015/03/03 04:14:50, yawano wrote:
> very small nit: We uses metadataList in this function with different meaning
> (for different type of variable). How about to use metadataLists here?

Done.

https://codereview.chromium.org/971173002/diff/40001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/gallery_data_model.js (right):

https://codereview.chromium.org/971173002/diff/40001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/gallery_data_model.js:104: item.metadataItem_,
On 2015/03/03 04:14:50, yawano wrote:
> Is this item.metadataItem_ updated for the new file?

Actually this should be oldItemMetadata.
The behavior is:

1. Gallery apps create new entry
2. replace the item's entry with the new entry, 
3. Add new item for old entry.

This is for keeping selection of updated item.
Fixed.

https://codereview.chromium.org/971173002/diff/40001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/image_editor/image_util.js (right):

https://codereview.chromium.org/971173002/diff/40001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/image_editor/image_util.js:521:
this.metadataModel_.get([entry], ['contentThumbnailTransform']).then(
On 2015/03/03 04:14:50, yawano wrote:
> Isn't this contentImageTransform instead of contentThumbnailTransform?

Good catch. Done.

[yawano, 2015-03-04 05:20:45]

https://codereview.chromium.org/971173002/diff/40001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/gallery_data_model.js (right):

https://codereview.chromium.org/971173002/diff/40001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/gallery_data_model.js:104: item.metadataItem_,
On 2015/03/04 05:07:04, hirono wrote:
> On 2015/03/03 04:14:50, yawano wrote:
> > Is this item.metadataItem_ updated for the new file?
> 
> Actually this should be oldItemMetadata.
> The behavior is:
> 
> 1. Gallery apps create new entry
> 2. replace the item's entry with the new entry, 
> 3. Add new item for old entry.
> 
> This is for keeping selection of updated item.
> Fixed.

I get it. Thank you!

https://codereview.chromium.org/971173002/diff/60001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/gallery_item.js (right):

https://codereview.chromium.org/971173002/diff/60001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/gallery_item.js:270: console.log(metadataItems);
Is this console output intentionally included in the production code? This seems
unnecessary for me.

https://codereview.chromium.org/971173002/diff/60001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/gallery_item.js:271: this.metadataItem =
metadataItems[0];
this.metadataItem_?

[hirono, 2015-03-04 05:32:45]

https://codereview.chromium.org/971173002/diff/60001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/gallery_item.js (right):

https://codereview.chromium.org/971173002/diff/60001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/gallery_item.js:270: console.log(metadataItems);
On 2015/03/04 05:20:45, yawano wrote:
> Is this console output intentionally included in the production code? This
seems
> unnecessary for me.

Done.

https://codereview.chromium.org/971173002/diff/60001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/gallery_item.js:271: this.metadataItem =
metadataItems[0];
On 2015/03/04 05:20:45, yawano wrote:
> this.metadataItem_?

Done.

[yawano, 2015-03-04 05:34:48]

lgtm. Thank you!

[hirono, 2015-03-04 05:38:28]

The CQ bit was checked by hirono@chromium.org

[hirono, 2015-03-04 05:38:35]

Thanks!

[commit-bot: I haz the power, 2015-03-04 05:39:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/971173002/100001

[hirono, 2015-03-04 08:28:14]

The CQ bit was checked by hirono@chromium.org

[hirono, 2015-03-04 08:28:15]

The patchset sent to the CQ was uploaded after l-g-t-m from yawano@chromium.org
Link to the patchset: https://codereview.chromium.org/971173002/#ps140001
(title: "Fix test.")

[commit-bot: I haz the power, 2015-03-04 08:28:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/971173002/140001

[commit-bot: I haz the power, 2015-03-04 09:02:04]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-03-04 09:02:39]

Patchset 8 (id:??) landed as
https://crrev.com/e8c5cdc06121a4435816d626e5490fd8f5e9e9b3
Cr-Commit-Position: refs/heads/master@{#319039}