Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 971163002: Files.app: Let MetadataCacheModel use cached URLs. (Closed)

Created:
5 years, 9 months ago by hirono
Modified:
5 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Let MetadataCacheModel use cached URLs. BUG=410766 TEST=None Committed: https://crrev.com/13218c15ac3328e80bf695f3b4b249fc420a63e2 Cr-Commit-Position: refs/heads/master@{#319221}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Fix test. #

Total comments: 2

Patch Set 5 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M ui/file_manager/file_manager/common/js/util.js View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js View 7 chunks +13 lines, -7 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_model_unittest.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
hirono
PTAL, thanks!
5 years, 9 months ago (2015-03-04 12:55:04 UTC) #2
hirono
On 2015/03/04 12:55:04, hirono wrote: > PTAL, thanks! I fixed the test. Thanks!
5 years, 9 months ago (2015-03-05 03:28:46 UTC) #3
fukino
https://codereview.chromium.org/971163002/diff/60001/ui/file_manager/file_manager/common/js/util.js File ui/file_manager/file_manager/common/js/util.js (right): https://codereview.chromium.org/971163002/diff/60001/ui/file_manager/file_manager/common/js/util.js#newcode770 ui/file_manager/file_manager/common/js/util.js:770: return entry['cachedUrl'] || entry.toURL(); Coudl you use entry.cachedUrl for ...
5 years, 9 months ago (2015-03-05 03:46:03 UTC) #4
hirono
https://codereview.chromium.org/971163002/diff/60001/ui/file_manager/file_manager/common/js/util.js File ui/file_manager/file_manager/common/js/util.js (right): https://codereview.chromium.org/971163002/diff/60001/ui/file_manager/file_manager/common/js/util.js#newcode770 ui/file_manager/file_manager/common/js/util.js:770: return entry['cachedUrl'] || entry.toURL(); On 2015/03/05 03:46:02, fukino wrote: ...
5 years, 9 months ago (2015-03-05 03:47:12 UTC) #5
fukino
On 2015/03/05 03:47:12, hirono wrote: > https://codereview.chromium.org/971163002/diff/60001/ui/file_manager/file_manager/common/js/util.js > File ui/file_manager/file_manager/common/js/util.js (right): > > https://codereview.chromium.org/971163002/diff/60001/ui/file_manager/file_manager/common/js/util.js#newcode770 > ...
5 years, 9 months ago (2015-03-05 04:10:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971163002/80001
5 years, 9 months ago (2015-03-05 04:54:40 UTC) #9
hirono
Thanks!
5 years, 9 months ago (2015-03-05 04:55:07 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-05 05:22:58 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 05:23:48 UTC) #12
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/13218c15ac3328e80bf695f3b4b249fc420a63e2
Cr-Commit-Position: refs/heads/master@{#319221}

Powered by Google App Engine
This is Rietveld 408576698