Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 971153002: Cherry pick HarfBuzz reverse_range fix (Closed)

Created:
5 years, 9 months ago by eae
Modified:
5 years, 9 months ago
Reviewers:
behdad_google, behdad
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cherry pick HarfBuzz reverse_range fix Cherry pick the HarfBuzz commit 8ac345e5c0ed0aad6547592ea0839aabfb4ba980 as it fixes a set of serious shaping regressions in the core text shaper on Mac OS. Cherry picking as opposed to rolling to allow for a clean DI. BUG=459043 TBR=behdad@chromium.org Committed: https://crrev.com/36504aa38b58939d103253524f2b9620ce998507 Cr-Commit-Position: refs/heads/master@{#318901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/harfbuzz-ng/src/hb-buffer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
behdad_google
lgtm
5 years, 9 months ago (2015-03-03 01:55:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971153002/1
5 years, 9 months ago (2015-03-03 16:34:19 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-03 16:34:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/971153002/1
5 years, 9 months ago (2015-03-03 16:51:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 17:35:10 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/36504aa38b58939d103253524f2b9620ce998507 Cr-Commit-Position: refs/heads/master@{#318901}
5 years, 9 months ago (2015-03-03 17:35:57 UTC) #10
behdad_google
5 years, 9 months ago (2015-03-04 18:40:47 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698