Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2417)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/CommandLineTest.java

Issue 971103003: Deflake CommandLineTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: delete test Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/CommandLineTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/CommandLineTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/CommandLineTest.java
deleted file mode 100644
index fa1b325102d676c58509fedfc8491ea23e98500b..0000000000000000000000000000000000000000
--- a/android_webview/javatests/src/org/chromium/android_webview/test/CommandLineTest.java
+++ /dev/null
@@ -1,55 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.android_webview.test;
-
-import android.os.Build;
-import android.test.suitebuilder.annotation.SmallTest;
-
-import org.chromium.android_webview.AwBrowserProcess;
-import org.chromium.base.CommandLine;
-import org.chromium.base.test.util.Feature;
-import org.chromium.base.test.util.MinAndroidSdkLevel;
-
-/**
- * Test suite for setting by the command line.
- */
-@MinAndroidSdkLevel(Build.VERSION_CODES.KITKAT)
-public class CommandLineTest extends AwTestBase {
- @Override
- protected boolean needsBrowserProcessStarted() {
- return false;
- }
-
- @SmallTest
- @Feature({"AndroidWebView"})
- public void testSetupCommandLine() throws Exception {
- // The commandline starts off in Java:
- CommandLine cl = CommandLine.getInstance();
- assertFalse(cl.isNativeImplementation());
-
- // We can add a switch.
- assertFalse(cl.hasSwitch("magic-switch"));
- cl.appendSwitchWithValue("magic-switch", "magic");
- assertTrue(cl.hasSwitch("magic-switch"));
- assertEquals("magic", cl.getSwitchValue("magic-switch"));
-
- // Setup Chrome.
- AwBrowserProcess.loadLibrary();
-
- // Now we should have switched to a native backed command line:
- cl = CommandLine.getInstance();
- assertTrue(cl.isNativeImplementation());
-
- // Our first switch is still there.
- assertTrue(cl.hasSwitch("magic-switch"));
- assertEquals("magic", cl.getSwitchValue("magic-switch"));
-
- // And we can add another one.
- assertFalse(cl.hasSwitch("more-magic-switch"));
- cl.appendSwitchWithValue("more-magic-switch", "more-magic");
- assertTrue(cl.hasSwitch("more-magic-switch"));
- assertEquals("more-magic", cl.getSwitchValue("more-magic-switch"));
- }
-}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698