Kill off JS_ErrorString type.

fpdfsdk/include/javascript/JS_Value.h

Index: fpdfsdk/include/javascript/JS_Value.h
diff --git a/fpdfsdk/include/javascript/JS_Value.h b/fpdfsdk/include/javascript/JS_Value.h
index e9faf32370ef3eb3bf3cbf0f8e90b2c3b67171cf..c4f846b47cb0c3713e4ca31e4bbec9f6bd8dac92 100644
--- a/fpdfsdk/include/javascript/JS_Value.h
+++ b/fpdfsdk/include/javascript/JS_Value.h
@@ -73,13 +73,16 @@ protected:
 	v8::Isolate* m_isolate;
 };
 
-template<class TYPE> class CJS_ParametersTmpl : public CFX_ArrayTemplate<TYPE>
+class CJS_Parameters : public CFX_ArrayTemplate<CJS_Value>
 {
 public:
-	void push_back(TYPE newElement){CFX_ArrayTemplate<TYPE>::Add(newElement);}
-	int size() const{return CFX_ArrayTemplate<TYPE>::GetSize();}
+	void push_back(CJS_Value newElement) {

[Lei Zhang, 2015/03/02 22:08:10]

const-ref while we are at it?

[Tom Sepez, 2015/03/02 22:14:51]

Done.

+        CFX_ArrayTemplate<CJS_Value>::Add(newElement);
+    }
+	int size() const {
+        return CFX_ArrayTemplate<CJS_Value>::GetSize();
+    }
 };
-typedef CJS_ParametersTmpl<CJS_Value> CJS_Parameters;
 
 class CJS_PropValue: public CJS_Value
 {