Kill off JS_ErrorString type.

fpdfsdk/include/javascript/JS_Value.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef _JS_VALUE_H_
 #define _JS_VALUE_H_
 
 class CJS_Array;
@@ skipping 55 matching lines @@
         FX_BOOL ConvertToArray(CJS_Array &) const;
         FX_BOOL ConvertToDate(CJS_Date &) const;
 
         v8::Isolate* GetIsolate() {return m_isolate;}
 protected:
         v8::Handle<v8::Value> m_pValue;
         FXJSVALUETYPE m_eType;
         v8::Isolate* m_isolate;
 };
 
-template<class TYPE> class CJS_ParametersTmpl : public CFX_ArrayTemplate<TYPE>
+class CJS_Parameters : public CFX_ArrayTemplate<CJS_Value>
 {
 public:
-        void push_back(TYPE newElement){CFX_ArrayTemplate<TYPE>::Add(newElement);}
-        int size() const{return CFX_ArrayTemplate<TYPE>::GetSize();}
+        void push_back(CJS_Value newElement) {

[Lei Zhang, 2015/03/02 22:08:10]

const-ref while we are at it?

[Tom Sepez, 2015/03/02 22:14:51]

Done.

+        CFX_ArrayTemplate<CJS_Value>::Add(newElement);
+    }
+        int size() const {
+        return CFX_ArrayTemplate<CJS_Value>::GetSize();
+    }
 };
-typedef CJS_ParametersTmpl<CJS_Value> CJS_Parameters;
 
 class CJS_PropValue: public CJS_Value
 {
 public:
         CJS_PropValue(const CJS_Value &);
         CJS_PropValue(v8::Isolate* isolate);
         ~CJS_PropValue();
 public:
         FX_BOOL IsSetting();
         FX_BOOL IsGetting();
@@ skipping 84 matching lines @@
 
         FX_BOOL IsValidDate();
 
 protected:
         v8::Handle<v8::Value> m_pDate;
         v8::Isolate* m_isolate;
 };
 
 #endif //_JS_VALUE_H_