Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 971033002: Kill off JS_ErrorString type. (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Kill off JS_ErrorString type. This provides no benefit, and reduces transparency. Along the way: Kill off some unused/commented-out code. Return void where a bool return doesn't make sense. Remove a pointless template type. Remove now unused constants and types. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e1671bd3158f5d78f66647ec5489e9538bd4bc36

Patch Set 1 #

Patch Set 2 : Whitespace, commented code. #

Total comments: 2

Patch Set 3 : Const reference. #

Patch Set 4 : Tabs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+531 lines, -590 lines) Patch
M fpdfsdk/include/fsdk_mgr.h View 6 chunks +6 lines, -35 lines 0 comments Download
M fpdfsdk/include/javascript/Document.h View 1 chunk +71 lines, -71 lines 0 comments Download
M fpdfsdk/include/javascript/Field.h View 1 chunk +78 lines, -78 lines 0 comments Download
M fpdfsdk/include/javascript/Icon.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/JS_Define.h View 6 chunks +8 lines, -20 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Value.h View 1 2 3 1 chunk +7 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/PublicMethods.h View 1 chunk +22 lines, -22 lines 0 comments Download
M fpdfsdk/include/javascript/app.h View 1 chunk +35 lines, -35 lines 0 comments Download
M fpdfsdk/include/javascript/color.h View 1 chunk +14 lines, -14 lines 0 comments Download
M fpdfsdk/include/javascript/console.h View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/event.h View 1 chunk +20 lines, -20 lines 0 comments Download
M fpdfsdk/include/javascript/global.h View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/report.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/javascript/util.h View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/jsapi/fxjs_v8.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 45 chunks +71 lines, -75 lines 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 63 chunks +78 lines, -78 lines 0 comments Download
M fpdfsdk/src/javascript/Icon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 19 chunks +22 lines, -22 lines 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 1 22 chunks +39 lines, -44 lines 0 comments Download
M fpdfsdk/src/javascript/color.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/console.cpp View 1 2 chunks +4 lines, -14 lines 0 comments Download
M fpdfsdk/src/javascript/event.cpp View 20 chunks +20 lines, -20 lines 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/report.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 1 5 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Lei, please review.
5 years, 9 months ago (2015-03-02 21:34:22 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/971033002/diff/20001/fpdfsdk/include/javascript/JS_Value.h File fpdfsdk/include/javascript/JS_Value.h (right): https://codereview.chromium.org/971033002/diff/20001/fpdfsdk/include/javascript/JS_Value.h#newcode79 fpdfsdk/include/javascript/JS_Value.h:79: void push_back(CJS_Value newElement) { const-ref while we are ...
5 years, 9 months ago (2015-03-02 22:08:10 UTC) #3
Tom Sepez
https://codereview.chromium.org/971033002/diff/20001/fpdfsdk/include/javascript/JS_Value.h File fpdfsdk/include/javascript/JS_Value.h (right): https://codereview.chromium.org/971033002/diff/20001/fpdfsdk/include/javascript/JS_Value.h#newcode79 fpdfsdk/include/javascript/JS_Value.h:79: void push_back(CJS_Value newElement) { On 2015/03/02 22:08:10, Lei Zhang ...
5 years, 9 months ago (2015-03-02 22:14:51 UTC) #4
Tom Sepez
5 years, 9 months ago (2015-03-02 22:20:15 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
e1671bd3158f5d78f66647ec5489e9538bd4bc36 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698