Issue 97103002: Fix corner-cases for WebVTT tokenizer escape handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 97103002: Fix corner-cases for WebVTT tokenizer escape handling (Closed)

Created:
7 years ago by fs

Modified:
7 years ago

Reviewers:
jochen (gone - plz use gerrit), Nate Chapin, Mike West

CC:
blink-reviews, nessy, philipj_slow, gasubic, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Fix corner-cases for WebVTT tokenizer escape handling Handle cases such as "&<", "&&", "&" followed by non-alphanumeric characters (and similar variations). Fix test tc022 which assumed that a single "&" would be ignored. TEST=media/track/opera/track/webvtt/parsing-cue-data/tests/entities.html BUG=321139 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162918

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -26 lines)			Patch
M	LayoutTests/media/track/captions-webvtt/tc022-entities.vtt	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	LayoutTests/media/track/captions-webvtt/tc022-entities-wrong.vtt	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/tests/entities-expected.txt	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	LayoutTests/media/track/track-webvtt-tc022-entities.html	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/media/track/track-webvtt-tc022-entities-expected.txt	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	Source/core/html/track/vtt/VTTTokenizer.cpp	View	1 chunk	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/97103002/1

7 years ago (2013-11-29 16:01:10 UTC) #3

Message was sent while issue was closed.

Change committed as 162918

Expand Messages | Collapse Messages