Issue 971013002: Merge to XFA: Return error information from pdfium to JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 971013002: Merge to XFA: Return error information from pdfium to JS. (Closed)

Created:
5 years, 9 months ago by Tom Sepez

Modified:
5 years, 9 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/master

Visibility:
Public.

Merge to XFA: Return error information from pdfium to JS. Cherry-pick from b720d0a14601f1496ef15297bc46d401f5a2a890 + Manually resolve merge conflicts + Fix more IWYU to fix compile. Original Review URL: https://codereview.chromium.org/963193003 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/3a83266acee37e99832adaf1337c6b3ab7559f50

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+174 lines, -115 lines)			Patch
M	fpdfsdk/include/javascript/IJavaScript.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_Define.h	View	13 chunks	+25 lines, -34 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_Object.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	fpdfsdk/include/javascript/resource.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/Document.cpp	View	10 chunks	+34 lines, -30 lines	0 comments	Download
M	fpdfsdk/src/javascript/console.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/global.cpp	View	3 chunks	+8 lines, -6 lines	0 comments	Download
M	fpdfsdk/src/javascript/resource.cpp	View	1 chunk	+16 lines, -1 line	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	testing/resources/javascript/document_props.in	View	1 chunk	+15 lines, -15 lines	0 comments	Download
M	testing/resources/javascript/document_props_expected.txt	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	testing/resources/javascript/globals.in	View	2 chunks	+33 lines, -11 lines	0 comments	Download
M	testing/resources/javascript/globals_expected.txt	View	3 chunks	+10 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Tom Sepez

Committed patchset #1 (id:1) manually as 3a83266acee37e99832adaf1337c6b3ab7559f50 (tree was closed).

5 years, 9 months ago (2015-03-02 20:59:10 UTC) #1

Message was sent while issue was closed.

lgtm