Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 970993002: [Chromoting] Remove extra comma after last element in JS dict. (Closed)

Created:
5 years, 9 months ago by garykac
Modified:
5 years, 9 months ago
Reviewers:
Jamie, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Remove extra comma after last element in JS dict. BUG= Committed: https://crrev.com/3553e9fd9a1306d6ac261fbc5fc142a2cf5c8d0f Cr-Commit-Position: refs/heads/master@{#318839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/webapp/app_remoting/js/app_remoting.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
garykac
5 years, 9 months ago (2015-03-02 19:33:34 UTC) #2
Jamie
LGTM. Is this a compiler error, or actually illegal JS?
5 years, 9 months ago (2015-03-02 19:43:05 UTC) #4
kelvinp
lgtm I think this is neither a JSCompiler error non illegal JS. I made the ...
5 years, 9 months ago (2015-03-02 19:47:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970993002/1
5 years, 9 months ago (2015-03-02 23:45:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 04:36:58 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 04:37:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3553e9fd9a1306d6ac261fbc5fc142a2cf5c8d0f
Cr-Commit-Position: refs/heads/master@{#318839}

Powered by Google App Engine
This is Rietveld 408576698