Fix Virtual Keyboard not being deployed in TouchView mode on Ozone.

Fix Virtual Keyboard not being deployed in TouchView mode on Ozone.

Ozone includes the internal keyboard in the active keyboard devices
even if the TV mode disables it due to the fact that the volume keys
can still be pressed. We now explicitly check the state of maximized
mode when deciding to show the keyboard.

TEST=VirtualKeyboardControllerAutoTest.EnabledDuringMaximizeMode, VirtualKeyboardControllerAutoTest.SuppressedInMaximizedMode
BUG=462666
Committed: https://crrev.com/d4f6a0b45733d769d4ba3bb1f0d6e9f67b930502
Cr-Commit-Position: refs/heads/master@{#318801}

[rsadam, 2015-03-02 20:07:02]

rsadam@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[rsadam, 2015-03-02 20:07:02]

Hi Peter, PTAL!

[pkotwicz, 2015-03-02 20:35:57]

LGTM

Thanks for fixing this!

https://codereview.chromium.org/970983003/diff/1/ash/virtual_keyboard_control...
File ash/virtual_keyboard_controller_unittest.cc (right):

https://codereview.chromium.org/970983003/diff/1/ash/virtual_keyboard_control...
ash/virtual_keyboard_controller_unittest.cc:157: // present.
Maybe update this comment?

https://codereview.chromium.org/970983003/diff/1/ash/virtual_keyboard_control...
ash/virtual_keyboard_controller_unittest.cc:238: // Tests maximized mode
interaction without disabling the internal keyboard.
A test that the virtual keyboard is surpressed if an external keyboard is
present and maximized mode is enabled might be useful

[rsadam, 2015-03-02 22:01:38]

https://codereview.chromium.org/970983003/diff/1/ash/virtual_keyboard_control...
File ash/virtual_keyboard_controller_unittest.cc (right):

https://codereview.chromium.org/970983003/diff/1/ash/virtual_keyboard_control...
ash/virtual_keyboard_controller_unittest.cc:157: // present.
On 2015/03/02 20:35:57, pkotwicz wrote:
> Maybe update this comment?

Done.

https://codereview.chromium.org/970983003/diff/1/ash/virtual_keyboard_control...
ash/virtual_keyboard_controller_unittest.cc:238: // Tests maximized mode
interaction without disabling the internal keyboard.
On 2015/03/02 20:35:57, pkotwicz wrote:
> A test that the virtual keyboard is surpressed if an external keyboard is
> present and maximized mode is enabled might be useful

Done.

[rsadam, 2015-03-02 22:02:35]

rsadam@chromium.org changed reviewers:
+ sky@chromium.org

[rsadam, 2015-03-02 22:02:36]

+sky for OWNERS: Please review changes in ash/*

[sky, 2015-03-02 23:03:01]

LGTM

[rsadam, 2015-03-02 23:03:46]

The CQ bit was checked by rsadam@chromium.org

[rsadam, 2015-03-02 23:03:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org
Link to the patchset: https://codereview.chromium.org/970983003/#ps20001 (title:
"Added suppression test.")

[commit-bot: I haz the power, 2015-03-02 23:04:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/970983003/20001

[pkotwicz, 2015-03-02 23:07:05]

The CQ bit was unchecked by pkotwicz@chromium.org

[rsadam, 2015-03-02 23:08:19]

On 2015/03/02 23:04:19, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/970983003/20001

Peter is going to verify it on an Ozone device as an extra sanity check. Waiting
for that before committing this.

[pkotwicz, 2015-03-02 23:22:46]

Double checked on a glimmer that this CL fixes the bug

[pkotwicz, 2015-03-02 23:22:49]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2015-03-02 23:23:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/970983003/20001

[commit-bot: I haz the power, 2015-03-02 23:50:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-02 23:52:32]

Patchset 2 (id:??) landed as
https://crrev.com/d4f6a0b45733d769d4ba3bb1f0d6e9f67b930502
Cr-Commit-Position: refs/heads/master@{#318801}