Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: net/docs/bug-triage.txt

Issue 970953002: Clarifications to network bug triage process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Results of self review. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 The Chrome network team uses a two day bug triage rotation. The main goals are 1 The Chrome network team uses a two day bug triage rotation. The main goals are
2 to identify and label new network bugs, and investigate network bugs when no 2 to identify and label new network bugs, and investigate network bugs when no
3 label seems suitable. 3 label seems suitable.
4 4
5 Responsibilities 5 Responsibilities
6 6
7 To be done on each rotation. These responsibilities should be tracked, and 7 Required:
8 anything left undone at the end of a rotation should be handed off to the next 8 * Identify new crashers
9 triager. The downside to passing along bug investigations like this is each new 9 * Identify new network issues.
10 * Request data about recent Cr-Internals-Network issue.
11 * Investigate each recent Cr-Internals-Network issue.
12 * Monitor UMA histograms and gasper alerts.
13
14 Best effort:
15 * Investigate unowned and owned-but-forgotten net/ crashers
16 * Investigate old bugs
17 * Close obsolete bugs.
18
19 All of the above is to be done on each rotation. These
20 responsibilities should be tracked, and anything left undone at the
21 end of a rotation should be handed off to the next triager. The
22 downside to passing along bug investigations like this is each new
10 triager has to get back up to speed on bugs the previous triager was 23 triager has to get back up to speed on bugs the previous triager was
11 investigating. The upside is that triagers don't get stuck investigating issues 24 investigating. The upside is that triagers don't get stuck
12 after their time after their rotation, and it results in a uniform, predictable 25 investigating issues after their time after their rotation, and it
13 two day commitment for all triagers. 26 results in a uniform, predictable two day commitment for all triagers.
14 27
15 Primary Responsibilities: 28 More detail:
29
30 Required activities:
16 * Identify new crashers that are potentially network related. You should check 31 * Identify new crashers that are potentially network related. You should check
17 the most recent canary, the previous canary (if the most recent less than a 32 the most recent canary, the previous canary (if the most recent less than a
18 day old), and any of dev/beta/stable that were released in the last couple 33 day old), and any of dev/beta/stable that were released in the last couple
19 of days, for each platform. File Cr-Internals-Network bugs on the tracker 34 of days, for each platform. File Cr-Internals-Network bugs on the tracker
20 when new crashers are found. 35 when new crashers are found.
21 * Identify new network bugs, both on the bug tracker and on the crash server. 36 * Identify new network bugs, both on the bug tracker and on the crash server.
22 All Unconfirmed issues filed during your triage rotation should be scanned, 37 All Unconfirmed issues filed during your triage rotation should be scanned,
23 and, for suspected network bugs, a network label assigned. A triager is 38 and, for suspected network bugs, a network label assigned. A triager is
24 responsible for looking at bugs reported from noon PST / 3:00 pm EST of the 39 responsible for looking at bugs reported from noon PST / 3:00 pm EST of the
25 last day of the previous triager's rotation until the same time on the last 40 last day of the previous triager's rotation until the same time on the last
26 day of their rotation. 41 day of their rotation.
27 * Request data about recent unassigned Cr-Internals-Network bugs from reporters. 42 * Request data about recent unassigned Cr-Internals-Network bugs from reporters.
28 "Recent" means issues updated in the past week or so. 43 "Recent" means issues updated in the past week or so. Note that
44 this means both pinging reporters for more information and
45 updating the bugs apporpriately when/if that information has come
46 in.
29 * Investigate each recent (New comment within the past week or so) 47 * Investigate each recent (New comment within the past week or so)
30 Cr-Internals-Network issue until you can do one of the following: 48 Cr-Internals-Network issue until you can do one of the following:
31 * Mark it as WontFix (working as intended, obsolete issue) or a duplicate. 49 * Mark it as WontFix (working as intended, obsolete issue) or a duplicate.
32 * Mark it as a feature request. 50 * Mark it as a feature request.
33 * Remove the Cr-Internals-Network label, replacing it with at least one more 51 * Remove the Cr-Internals-Network label, replacing it with at least one more
34 specific network label or non-network label. Promptly adding non-network 52 specific network label or non-network label. Promptly adding non-network
35 labels when appropriate is important to get new bugs in front of someone 53 labels when appropriate is important to get new bugs in front of someone
36 familiar with the relevant code, and to remove them from the next triager's 54 familiar with the relevant code, and to remove them from the next triager's
37 radar. Because of the way the bug report wizard works, a lot of bugs 55 radar. Because of the way the bug report wizard works, a lot of bugs
38 incorrectly end up with the network label. 56 incorrectly end up with the network label.
39 * The issue is assigned to an appropriate owner. 57 * The issue is assigned to an appropriate owner.
40 * If there is no more specific label for a bug, it should be investigated 58 * If there is no more specific label for a bug, it should be investigated
41 until we have a good understanding of the cause of the problem, and some 59 until we have a good understanding of the cause of the problem, and some
42 idea how it should be fixed, at which point its status should be set to 60 idea how it should be fixed, at which point its status should be set to
43 Available. Future triagers should ignore bugs with this status, unless 61 Available. Future triagers should ignore bugs with this status, unless
44 investigating stale bugs. 62 investigating stale bugs.
45 * Monitor UMA histograms and gasper alerts. 63 * Monitor UMA histograms and gasper alerts.
46 TODO (mmenke): Add a suggested workflow. 64 * For each Gasper alert that fires, the triager should determine if
65 the alert is real (not due to noise), and file a bug with the
66 appropriate label if so. Note that if no more specifical label
mmenke 2015/03/02 19:15:13 "no more specifical label" -> "no label more speci
Randy Smith (Not in Mondays) 2015/03/03 15:08:02 Done.
67 than Cr-Internals-Network is appropriate, the responsibility
68 remains with the triager to continue investigating the bug, as
69 above.
47 70
48 Best Effort (As you time): 71 Best Effort (As you have time):
49 * Investigate unowned and owned but forgotten net/ crashers that are still 72 * Investigate unowned and owned but forgotten net/ crashers that are still
50 occurring (As indicated by go/chromecrash), prioritizing frequent and long 73 occurring (As indicated by go/chromecrash), prioritizing frequent and long
51 standing crashers. 74 standing crashers.
52 * Investigate old bugs, prioritizing the most recent. 75 * Investigate old bugs, prioritizing the most recent.
53 * Close obsolete bugs. 76 * Close obsolete bugs.
54 77
55 If you've investigated an issue (in code you don't normally work on) to an 78 If you've investigated an issue (in code you don't normally work on) to an
56 extent that you know how to fix it, and the fix is simple, feel free to take 79 extent that you know how to fix it, and the fix is simple, feel free to take
57 ownership of the issue and create a patch while on triage duty, but other tasks 80 ownership of the issue and create a patch while on triage duty, but other tasks
58 should take priority. 81 should take priority.
59 82
60 See bug-triage-suggested-workflow.txt for suggested workflows. 83 See bug-triage-suggested-workflow.txt for suggested workflows.
61 See bug-triage-labels.txt for labeling tips for network and non-network bugs. 84 See bug-triage-labels.txt for labeling tips for network and non-network bugs.
OLDNEW
« no previous file with comments | « no previous file | net/docs/bug-triage-suggested-workflow.txt » ('j') | net/docs/bug-triage-suggested-workflow.txt » ('J')

Powered by Google App Engine
This is Rietveld 408576698