Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: net/docs/bug-triage-suggested-workflow.txt

Issue 970953002: Clarifications to network bug triage process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reorganized dealing with Needs-Feedback label Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/docs/bug-triage.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Look for new crashers:
2 * Go to go/chromecrash.
3 * For each platform, look through the releases for which releases to
4 investigate. As per bug-triage.txt, this should be the
5 most recent canary, the previous canary (if the most recent is less
6 than a day old), and any of dev/beta/stable that were released in the
7 last couple of days.
8 * For each release, in the "Process Type" frame, click on "browser".
9 * At the bottom of the "Magic Signature" frame, click "limit 1000".
10 Reported crashers are sorted in decreasing order of the number of reports for
11 that crash signature.
12 * Search the page for "net::".
13 * For each found signature:
14 * If there is a bug already filed, make sure it is correctly
15 describing the current bug (e.g. not closed, or not describing a
16 long-past issue), and make sure that if it is a net:: bug, that
17 it is labeled as such.
18 * Ignore signatures that only occur once, as memory corruption can
19 easily cause one-off failures when the sample size is large
20 enough.
21 * Ignore signatures that only come from a single client ID, as
22 individual machine malware and breakage can also easily cause
23 one-off failures.
24 * Click on the number of reports field to see details of
25 crash. Ignore it if it doesn't appear to be a network bug.
26 * Otherwise, file a new bug directly from chromecrash. Note that
27 this may result in filing bugs for low- and very-low- frequency
28 crashes. That's ok; the bug tracker is a better tool to figure
29 out whether or not we put resources into those crashes than a snap
30 judgement when filing bugs.
31 * For each bug you file, include the following information:
32 * The backtrace. Note that the backtrace should not be added to the
33 bug if Restrict-View-Google isn't set on the bug as it may contain
34 PII. Filing the bug from the crash reporter should do this
35 automatically, but check.
36 * The channel in which the bug is seen (canary/dev/beta/stable),
37 its frequency in that channel, and its rank among crashers in the channel.
38 * The frequency of this signature in recent releases. This
39 information is available by:
40 * Clicking on the signature in the "Magic Signature" list
41 * Clicking "Edit" on the dremel query at the top of the page
42 * Removing the "product.version='X.Y.Z.W' AND" string and clicking
43 "Update".
44 * Clicking "Limit 1000" in the Product Version list in the
45 resulting page (without this, the listing will be restricted to
46 the releases in which the signature is most common, which will
47 often not include the canary/dev release being investigated).
48 * Choose some subset of that list, or all of it, to include in the
49 bug. Make sure to indicate if there is a defined point in the
50 past before which the signature is not present.
51
1 Identifying unlabeled network bugs on the tracker: 52 Identifying unlabeled network bugs on the tracker:
2 * Look at new uncomfirmed bugs since noon PST on the last triager's rotation: 53 * Look at new uncomfirmed bugs since noon PST on the last triager's rotation:
3 https://code.google.com/p/chromium/issues/list?can=2&q=status%3Aunconfirmed& sort=-id&num=1000 54 https://code.google.com/p/chromium/issues/list?can=2&q=status%3Aunconfirmed& sort=-id&num=1000
4 * Press "h" to bring up a preview of the bug text. 55 * Press "h" to bring up a preview of the bug text.
5 * Use "j" and "k" to advance through bugs. 56 * Use "j" and "k" to advance through bugs.
6 * If a bug looks like it might be network/download/safe-browsing related, middle 57 * If a bug looks like it might be network/download/safe-browsing related, middle
7 click [or command-click on OSX] to open in new tab. 58 click [or command-click on OSX] to open in new tab.
8 * If a user provides a crash ID for a crasher for a bug that could be 59 * If a user provides a crash ID for a crasher for a bug that could be
9 net-related, look at the crash stack at go/crash, and see if it looks to be 60 net-related, look at the crash stack at go/crash, and see if it looks to be
10 network related. Be sure to check if other bug reports have that stack 61 network related. Be sure to check if other bug reports have that stack
(...skipping 10 matching lines...) Expand all
21 * If non-network causes also seem possible, attach those labels as well. 72 * If non-network causes also seem possible, attach those labels as well.
22 73
23 Investigating Cr-Internals-Network bugs: 74 Investigating Cr-Internals-Network bugs:
24 * It's recommended that while on triage duty, you subscribe to the 75 * It's recommended that while on triage duty, you subscribe to the
25 Cr-Internals-Network label. To do this, go to 76 Cr-Internals-Network label. To do this, go to
26 https://code.google.com/p/chromium/issues/ and click on "Subscriptions". 77 https://code.google.com/p/chromium/issues/ and click on "Subscriptions".
27 Enter Cr-Internals-Network and click submit. 78 Enter Cr-Internals-Network and click submit.
28 * Look through uncomfirmed and untriaged Cr-Internals-Network bugs, prioritizing 79 * Look through uncomfirmed and untriaged Cr-Internals-Network bugs, prioritizing
29 those updated within the last week: 80 those updated within the last week:
30 https://code.google.com/p/chromium/issues/list?can=2&q=Cr%3DInternals-Networ k+-status%3AAssigned+-status%3AStarted+-status%3AAvailable+&sort=-modified 81 https://code.google.com/p/chromium/issues/list?can=2&q=Cr%3DInternals-Networ k+-status%3AAssigned+-status%3AStarted+-status%3AAvailable+&sort=-modified
82 * If more information is needed from the reporter, ask for it and
83 add the 'Needs-Feedback' label. If the reporter has answered an
84 earlier request for information, remove that label.
31 * While investigating a new issue, change the status to Untriaged. 85 * While investigating a new issue, change the status to Untriaged.
32 * If a bug is a potential security issue (Allows for code execution from remote 86 * If a bug is a potential security issue (Allows for code execution from remote
33 site, allows crossing security boundaries, unchecked array bounds, etc) mark 87 site, allows crossing security boundaries, unchecked array bounds, etc) mark
34 it Type-Bug-Security. If it has privacy implication (History, cookies 88 it Type-Bug-Security. If it has privacy implication (History, cookies
35 discoverable by an entity that shouldn't be able to do so, incognito state 89 discoverable by an entity that shouldn't be able to do so, incognito state
36 being saved in memory or on disk beyond the lifetime of incognito tabs, 90 being saved in memory or on disk beyond the lifetime of incognito tabs,
37 etc), mark it Cr-Privacy. 91 etc), mark it Cr-Privacy.
38 * For bugs that already have a more specific network label, go ahead and remove 92 * For bugs that already have a more specific network label, go ahead and remove
39 the Cr-Internals-Network label and move on. 93 the Cr-Internals-Network label and move on.
40 * Try to figure out if it's really a network bug. See common non-network labels 94 * Try to figure out if it's really a network bug. See common non-network labels
(...skipping 27 matching lines...) Expand all
68 strongly suspect CLs. 122 strongly suspect CLs.
69 * If you are having trouble with an issue, particularly for help understanding 123 * If you are having trouble with an issue, particularly for help understanding
70 net-internals logs, email the public net-dev@chromium.org list for help 124 net-internals logs, email the public net-dev@chromium.org list for help
71 debugging. If it's a crasher, or for some other reason discussion needs to 125 debugging. If it's a crasher, or for some other reason discussion needs to
72 be done in private, use chrome-network-debugging@google.com. 126 be done in private, use chrome-network-debugging@google.com.
73 TODO(mmenke): Write up a net-internals tips and tricks docs. 127 TODO(mmenke): Write up a net-internals tips and tricks docs.
74 * If it appears to be a bug in the unowned core of the network stack (i.e. no 128 * If it appears to be a bug in the unowned core of the network stack (i.e. no
75 sublabel applies, or only the Cr-Internals-Network-HTTP sublabel applies, 129 sublabel applies, or only the Cr-Internals-Network-HTTP sublabel applies,
76 and there's no clear owner), try to figure out the exact cause. 130 and there's no clear owner), try to figure out the exact cause.
77 131
78 Look for new crashers: 132 Monitor UMA histograms and gasper alerts. For each Gasper alert that
79 * Go to go/chromecrash. 133 fires, determine if it's a real alert and file a bug if so.
80 * For each platform, go to the latest canary. 134 * Don't file if the alert is coincident with a major volume change.
81 * In the "Process Type" frame, click on "browser". 135 The volume at a particular date can be determined by hovering the
82 * At the bottom of the "Magic Signature" frame, click "limit 1000". 136 mouse over the appropriate location on the alert line.
83 Reported crashers are sorted in decreasing order of the number of reports for 137 * Don't file if the alert is on a graph with very low volume (< ~200
84 that crash signature. 138 data points); it's probably noise, and we probably don't care even
85 * Search the page for "net::". Ignore crashes that only occur once, as 139 if it isn't.
86 memory corruption can easily cause one-off failures when the sample size is 140 * Don't file if the graph is really noisy (but eyeball it to decide if
87 large enough. 141 there is an underlying important shift under the noise).
88 * Click on the number of reports field to see details of crash. Look at the 142 * Don't file if the alert is in the "Known Ignorable" list:
89 stack trace to confirm it's a network bug. 143 * SimpleCache on Windows
90 * If it is, and there's no associated bug filed, file a new bug directly from 144 * DiskCache on Android.
91 chromecrash, looking at earlier canaries to determine if it's a recent 145 For each Gasper alert, respond to chrome-network-debugging@ with a
92 regression. Use the most specific label possible. 146 summary of the action you've taken and why, including issue link if an
93 * The most recent Canary may not yet have a full day of crashes, so it may be 147 issue was filed.
94 worth looking at more than one version.
95 * If there's been a dev, beta, or stable release in the last couple days, should
96 also look at those.
97 148
98 Investigating crashers: 149 Investigating crashers:
99 * Only investigate crashers that are still occurring, as identified by above 150 * Only investigate crashers that are still occurring, as identified by above
100 section. If a search on go/crash indicates a crasher is no longer 151 section. If a search on go/crash indicates a crasher is no longer
101 occurring, mark it as WontFix. 152 occurring, mark it as WontFix.
102 * Particularly for Windows, look for weird dlls associated with the crashes. 153 * Particularly for Windows, look for weird dlls associated with the crashes.
103 If there are some, it may be caused by malware. You can often figure out if 154 If there are some, it may be caused by malware. You can often figure out if
104 a dll is malware by a search, though it's harder to figure out if a dll is 155 a dll is malware by a search, though it's harder to figure out if a dll is
105 definitively not malware. 156 definitively not malware.
106 * See if the same users are repeatedly running into the same issue. This can be 157 * See if the same users are repeatedly running into the same issue. This can be
(...skipping 17 matching lines...) Expand all
124 * If a bug is over 2 months old, and the underlying problem was never 175 * If a bug is over 2 months old, and the underlying problem was never
125 reproduced or really understood: 176 reproduced or really understood:
126 * If it's over a year old, go ahead and mark the issue as Archived. 177 * If it's over a year old, go ahead and mark the issue as Archived.
127 * Otherwise, ask reporters if the issue is still present, and attach the 178 * Otherwise, ask reporters if the issue is still present, and attach the
128 Needs-Feedback label. 179 Needs-Feedback label.
129 * Old unconfirmed or untriaged Cr-Internals-Network issues can be investigated 180 * Old unconfirmed or untriaged Cr-Internals-Network issues can be investigated
130 just like newer ones. Crashers should generally be given higher priority, 181 just like newer ones. Crashers should generally be given higher priority,
131 since we can verify if they still occur, and then newer issues, as they're 182 since we can verify if they still occur, and then newer issues, as they're
132 more likely to still be present, and more likely to have a still responsive 183 more likely to still be present, and more likely to have a still responsive
133 bug reporter. 184 bug reporter.
OLDNEW
« no previous file with comments | « net/docs/bug-triage.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698