chrome/android/java/src/org/chromium/chrome/browser/Tab.java - Issue 970883002: [Android WebView] Synthesize a fake page loading event on page source modification (Re-land)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 970883002: [Android WebView] Synthesize a fake page loading event on page source modification (Re-land) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java ('K') | « android_webview/native/aw_web_contents_delegate.cc ('k') | components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

index 2c631663f8dd7e7fa0946e1bd1c55d0f755cfa77..267272f7bb00432f8e2eabc7eeb1111f1530aad5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

@@ -49,6 +49,7 @@ import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.ContentViewClient;

import org.chromium.content.browser.ContentViewCore;

import org.chromium.content.browser.WebContentsObserver;

+import org.chromium.content_public.browser.InvalidateTypes;

import org.chromium.content_public.browser.LoadUrlParams;

import org.chromium.content_public.browser.WebContents;

import org.chromium.content_public.common.Referrer;

@@ -387,10 +388,10 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

@Override

public void navigationStateChanged(int flags) {

- if ((flags & INVALIDATE_TYPE_TITLE) != 0) {

+ if ((flags & InvalidateTypes.TITLE) != 0) {

for (TabObserver observer : mObservers) observer.onTitleUpdated(Tab.this);

}

- if ((flags & INVALIDATE_TYPE_URL) != 0) {

+ if ((flags & InvalidateTypes.URL) != 0) {

for (TabObserver observer : mObservers) observer.onUrlUpdated(Tab.this);

}