Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3058)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

Issue 970883002: [Android WebView] Synthesize a fake page loading event on page source modification (Re-land) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java b/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java
index c3c381a6bd341a6fe3ed36f069f0ac4c37bbf15c..fde840c2945715bfe32481f347df6cf5cdf3b455 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java
@@ -13,12 +13,17 @@ import org.chromium.net.NetError;
*/
public class AwWebContentsObserver extends WebContentsObserver {
private final AwContentsClient mAwContentsClient;
+ private boolean mDidStartProvisionalLoadForFrameFired = false;
Charlie Reis 2015/03/03 22:21:01 nit: Did...Fired sounds strange to me, but I'll de
mnaganov (inactive) 2015/03/04 10:30:29 Yeah. I was so much tired battling with the code t
public AwWebContentsObserver(WebContents webContents, AwContentsClient awContentsClient) {
super(webContents);
mAwContentsClient = awContentsClient;
}
+ boolean getDidStartProvisionalLoadForFrameFired() {
+ return mDidStartProvisionalLoadForFrameFired;
+ }
+
@Override
public void didFinishLoad(long frameId, String validatedUrl, boolean isMainFrame) {
String unreachableWebDataUrl = AwContentsStatics.getUnreachableWebDataUrl();
@@ -67,4 +72,15 @@ public class AwWebContentsObserver extends WebContentsObserver {
public void didNavigateAnyFrame(String url, String baseUrl, boolean isReload) {
mAwContentsClient.doUpdateVisitedHistory(url, isReload);
}
+
+ @Override
+ public void didStartProvisionalLoadForFrame(
+ long frameId,
+ long parentFrameId,
+ boolean isMainFrame,
+ String validatedUrl,
+ boolean isErrorPage,
+ boolean isIframeSrcdoc) {
+ mDidStartProvisionalLoadForFrameFired = true;
+ }
}

Powered by Google App Engine
This is Rietveld 408576698