Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 970863003: app_list::StartPageService: Document and check nulls. (Closed)

Created:
5 years, 9 months ago by Matt Giuca
Modified:
5 years, 9 months ago
Reviewers:
xiyuan, calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, sadrul, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

app_list::StartPageService: Document and check nulls. This adds null checks for the result of StartPageService::Get in a few places where it was missing. Committed: https://crrev.com/6a94f6890f6130e11c62aa1642d307d1f2c69e05 Cr-Commit-Position: refs/heads/master@{#318985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/ui/app_list/start_page_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/start_page_service_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_service_ash.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/app_list/start_page_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Matt Giuca
5 years, 9 months ago (2015-03-03 03:58:25 UTC) #2
xiyuan
lgtm
5 years, 9 months ago (2015-03-03 04:45:16 UTC) #3
calamity
lgtm.
5 years, 9 months ago (2015-03-03 07:27:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970863003/1
5 years, 9 months ago (2015-03-03 22:55:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 00:56:15 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 00:56:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a94f6890f6130e11c62aa1642d307d1f2c69e05
Cr-Commit-Position: refs/heads/master@{#318985}

Powered by Google App Engine
This is Rietveld 408576698