Source/bindings/scripts/v8_types.py - Issue 970843002: IDL: Implement float/double correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 970843002: IDL: Implement float/double correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_types.py

diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py

index 27ef87e8000f25b536e3bbec4c32260b336da538..66222fbec11b235ee946aa651575eaa12784a6c6 100644

--- a/Source/bindings/scripts/v8_types.py

+++ b/Source/bindings/scripts/v8_types.py

@@ -551,11 +551,6 @@ def v8_value_to_cpp_value(idl_type, extended_attributes, v8_value, variable_name

arguments = v8_value

if base_idl_type in V8_VALUE_TO_CPP_VALUE:

- # FIXME: Once float/double are implemented per-specification (without

- # [TypeChecking=Unrestricted]) this special handling can be dropped.

- # http://crbug.com/354298

- if base_idl_type in ('float', 'double') and not restricted_float:

- base_idl_type = 'unrestricted ' + base_idl_type

cpp_expression_format = V8_VALUE_TO_CPP_VALUE[base_idl_type]

elif idl_type.is_array_buffer_or_view:

cpp_expression_format = (