Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 970833003: [Android] Hide handles during stylus selection

Created:
5 years, 9 months ago by AviD
Modified:
5 years, 9 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Hide handles during stylus selection Added code to temporarily hide Selection handles during stylus selection so that it has uniform behavior. BUG=463097

Patch Set 1 #

Patch Set 2 : Dismiss handles on start #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
AviD
jdduke@ Could you please take a look?
5 years, 9 months ago (2015-03-02 13:38:48 UTC) #2
jdduke (slow)
+changwan
5 years, 9 months ago (2015-03-02 16:04:39 UTC) #4
AviD
@Changwan Ryu : Could you PTAL?
5 years, 9 months ago (2015-03-05 05:19:29 UTC) #5
Changwan Ryu
On 2015/03/05 05:19:29, AviD wrote: > @Changwan Ryu : Could you PTAL? Currently, when we ...
5 years, 9 months ago (2015-03-05 09:52:25 UTC) #6
AviD
On 2015/03/05 09:52:25, Changwan Ryu wrote: > On 2015/03/05 05:19:29, AviD wrote: > > @Changwan ...
5 years, 9 months ago (2015-03-05 14:43:46 UTC) #7
Changwan Ryu
On 2015/03/05 14:43:46, AviD wrote: > On 2015/03/05 09:52:25, Changwan Ryu wrote: > > On ...
5 years, 9 months ago (2015-03-05 23:56:15 UTC) #8
jdduke (slow)
> Samsung's SPen Selection on Browser has a different behavior. It triggers > multiple selections ...
5 years, 9 months ago (2015-03-06 00:08:00 UTC) #9
AviD
5 years, 9 months ago (2015-03-06 12:32:00 UTC) #10
On 2015/03/06 00:08:00, jdduke wrote:
> > Samsung's SPen Selection on Browser has a different behavior. It triggers
> > multiple selections with SPen after the first selection.
> 
> Is there a video I can see of the current SPen behavior? My concern here is
> jitter mainly with WebView, where the action bar appearance will often shift
the
> embedded content.

Attached the video (with the issue and with the fix) in the bug.

Powered by Google App Engine
This is Rietveld 408576698