Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 970823002: Make ScrollToOptions members unrestricted doubles (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make ScrollToOptions members unrestricted doubles They are already unrestricted in practice since the dictionary doesn't have [TypeChecking=Unrestricted], so this doesn't change behavior. Firefox also implements them as unrestricted. BUG=354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M Source/core/frame/ScrollToOptions.idl View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL These are the final two "implicitly" unrestricted doubles. I.e., after this, we can drop ...
5 years, 9 months ago (2015-03-02 09:57:07 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-02 10:15:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970823002/1
5 years, 9 months ago (2015-03-02 10:16:51 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 12:54:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191099

Powered by Google App Engine
This is Rietveld 408576698