Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Issue 970813003: Make sure content offset gets updated (Closed)

Created:
5 years, 9 months ago by Changwan Ryu
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure content offset gets updated On Webapp, touch gestures are offset by the size of the toolbar, even when the toolbar is hidden. This occurs because we assume that the previous content offset can never be 0, ending up not calling onVisibleContentOffsetChanged() callback. We can fix it by initializing previous content offset as NaN. BUG=459275 Committed: https://crrev.com/19f04a05b39e5586cba79eaba009ae675ca6aad1 Cr-Commit-Position: refs/heads/master@{#318974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Changwan Ryu
5 years, 9 months ago (2015-03-03 05:22:19 UTC) #2
David Trainor- moved to gerrit
+1 but let Ted confirm.
5 years, 9 months ago (2015-03-03 06:28:28 UTC) #3
Ted C
lgtm
5 years, 9 months ago (2015-03-03 19:13:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970813003/1
5 years, 9 months ago (2015-03-03 23:49:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 00:16:23 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 00:17:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19f04a05b39e5586cba79eaba009ae675ca6aad1
Cr-Commit-Position: refs/heads/master@{#318974}

Powered by Google App Engine
This is Rietveld 408576698