Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 970803002: [x86] Improve code generation for context materialization. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x86] Improve code generation for context materialization. On Intel targets, it is cheaper to load the context from the frame instead of loading the context as a constant (which usually involves a PropertyCell because the context is in new space when we compile the function). R=jarin@chromium.org Committed: https://crrev.com/502898ef60f011e3d4150cac8815c001928d6a26 Cr-Commit-Position: refs/heads/master@{#26935}

Patch Set 1 #

Patch Set 2 : Fix ia32. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 1 1 chunk +13 lines, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-02 07:39:03 UTC) #1
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-03-02 07:39:22 UTC) #2
Jarin
lgtm
5 years, 9 months ago (2015-03-02 08:15:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970803002/20001
5 years, 9 months ago (2015-03-02 08:22:13 UTC) #6
Benedikt Meurer
Committed patchset #2 (id:20001) manually as 502898ef60f011e3d4150cac8815c001928d6a26 (presubmit successful).
5 years, 9 months ago (2015-03-02 09:09:48 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 09:09:52 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/502898ef60f011e3d4150cac8815c001928d6a26
Cr-Commit-Position: refs/heads/master@{#26935}

Powered by Google App Engine
This is Rietveld 408576698