Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 970713002: Try to fix bitmaptools declaration in gn_migration.gypi. (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try to fix bitmaptools declaration in gn_migration.gypi. I think the analyze generator is getting confused by a mismatch between bitmaptools and bitmaptools#host, but am not sure, so this is a speculative fix. TBR=brettw@chromium.org Committed: https://crrev.com/379e4987df67c0525a6f6950c10c461e2cd5115f Cr-Commit-Position: refs/heads/master@{#318634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M build/gn_migration.gypi View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Dirk Pranke
5 years, 9 months ago (2015-03-01 22:13:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970713002/1
5 years, 9 months ago (2015-03-01 22:18:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-01 23:18:21 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-01 23:18:49 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/379e4987df67c0525a6f6950c10c461e2cd5115f
Cr-Commit-Position: refs/heads/master@{#318634}

Powered by Google App Engine
This is Rietveld 408576698