content/browser/service_worker/service_worker_provider_host.cc - Issue 970693003: ServiceWorker: plumbing for ClientQueryOptions (2/2, chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 970693003: ServiceWorker: plumbing for ClientQueryOptions (2/2, chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/service_worker/service_worker_provider_host.cc

diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc

index 6dd627c3b89362457e934300b1289c2a871b0366..561724b9337ac3270ba9408bf7aaf79e6760e996 100644

--- a/content/browser/service_worker/service_worker_provider_host.cc

+++ b/content/browser/service_worker/service_worker_provider_host.cc

@@ -46,7 +46,8 @@ ServiceWorkerClientInfo GetClientInfoOnUIThread(

render_frame_host->IsFocused(),

render_frame_host->GetLastCommittedURL(),

render_frame_host->GetParent() ? REQUEST_CONTEXT_FRAME_TYPE_NESTED

- : REQUEST_CONTEXT_FRAME_TYPE_TOP_LEVEL);

+ : REQUEST_CONTEXT_FRAME_TYPE_TOP_LEVEL,

+ blink::WebServiceWorkerClientTypeWindow);

falken 2015/03/04 07:16:42 maybe I'm lost, how do we know this is a window an

kinuko 2015/03/05 02:30:23 We collect these clients using render_frame_id, wh

falken 2015/03/05 14:23:01 Acknowledged.

}

ServiceWorkerClientInfo FocusOnUIThread(

« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_version.h » ('j') | content/common/service_worker/service_worker_messages.h » ('J')