Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: content/renderer/service_worker/service_worker_script_context.cc

Issue 970693003: ServiceWorker: plumbing for ClientQueryOptions (2/2, chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase build fix... Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/service_worker/service_worker_script_context.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/service_worker/service_worker_script_context.cc
diff --git a/content/renderer/service_worker/service_worker_script_context.cc b/content/renderer/service_worker/service_worker_script_context.cc
index b94323e62556ce62729ef8b7e00773aa4920f142..2f731dba2711ad428a8f99ebe67c289ed580ff27 100644
--- a/content/renderer/service_worker/service_worker_script_context.cc
+++ b/content/renderer/service_worker/service_worker_script_context.cc
@@ -18,6 +18,7 @@
#include "ipc/ipc_message.h"
#include "third_party/WebKit/public/platform/WebCrossOriginServiceWorkerClient.h"
#include "third_party/WebKit/public/platform/WebReferrerPolicy.h"
+#include "third_party/WebKit/public/platform/WebServiceWorkerClientQueryOptions.h"
#include "third_party/WebKit/public/platform/WebServiceWorkerRequest.h"
#include "third_party/WebKit/public/platform/WebString.h"
#include "third_party/WebKit/public/platform/WebURL.h"
@@ -85,6 +86,7 @@ ToWebServiceWorkerClientInfo(const ServiceWorkerClientInfo& client_info) {
web_client_info.isFocused = client_info.is_focused;
web_client_info.url = client_info.url;
web_client_info.frameType = GetBlinkFrameType(client_info.frame_type);
+ web_client_info.clientType = client_info.client_type;
return web_client_info;
}
@@ -118,8 +120,8 @@ void ServiceWorkerScriptContext::OnMessageReceived(
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_MessageToWorker, OnPostMessage)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_CrossOriginMessageToWorker,
OnCrossOriginMessageToWorker)
- IPC_MESSAGE_HANDLER(ServiceWorkerMsg_DidGetClientDocuments,
- OnDidGetClientDocuments)
+ IPC_MESSAGE_HANDLER(ServiceWorkerMsg_DidGetClients,
+ OnDidGetClients)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_OpenWindowResponse,
OnOpenWindowResponse)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_OpenWindowError,
@@ -221,12 +223,16 @@ void ServiceWorkerScriptContext::DidHandleCrossOriginConnectEvent(
GetRoutingID(), request_id, accept_connection));
}
-void ServiceWorkerScriptContext::GetClientDocuments(
+void ServiceWorkerScriptContext::GetClients(
+ const blink::WebServiceWorkerClientQueryOptions& weboptions,
blink::WebServiceWorkerClientsCallbacks* callbacks) {
DCHECK(callbacks);
int request_id = pending_clients_callbacks_.Add(callbacks);
- Send(new ServiceWorkerHostMsg_GetClientDocuments(
- GetRoutingID(), request_id));
+ ServiceWorkerClientQueryOptions options;
+ options.client_type = weboptions.clientType;
+ options.include_uncontrolled = weboptions.includeUncontrolled;
+ Send(new ServiceWorkerHostMsg_GetClients(
+ GetRoutingID(), request_id, options));
}
void ServiceWorkerScriptContext::OpenWindow(
@@ -444,10 +450,10 @@ void ServiceWorkerScriptContext::OnCrossOriginMessageToWorker(
proxy_->dispatchCrossOriginMessageEvent(web_client, message, ports);
}
-void ServiceWorkerScriptContext::OnDidGetClientDocuments(
+void ServiceWorkerScriptContext::OnDidGetClients(
int request_id, const std::vector<ServiceWorkerClientInfo>& clients) {
TRACE_EVENT0("ServiceWorker",
- "ServiceWorkerScriptContext::OnDidGetClientDocuments");
+ "ServiceWorkerScriptContext::OnDidGetClients");
blink::WebServiceWorkerClientsCallbacks* callbacks =
pending_clients_callbacks_.Lookup(request_id);
if (!callbacks) {
« no previous file with comments | « content/renderer/service_worker/service_worker_script_context.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698