Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 970623002: Revert of Roll Clang 223108:230631 (+revert of r229678) (Closed)

Created:
5 years, 9 months ago by hans
Modified:
5 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, dmikurube+clang_chromium.org, eugenis+clang_chromium.org, jam, rickyz+watch_chromium.org, glider+clang_chromium.org, darin-cc_chromium.org, ukai+watch_chromium.org, piman+watch_chromium.org, jln+watch_chromium.org
Base URL:
precise:/work/chromium/src@clang_roll_230341
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll Clang 223108:230631 (+revert of r229678) (patchset #5 id:80001 of https://codereview.chromium.org/959443002/) Reason for revert: Linux Chrome build is broken: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/56230 Original issue's description: > Roll Clang 223108:230631 (+revert of r229678) > > Also introduce a build number in the package name, stop versioning > the Blink GC plugin, and remove repackage.sh. > > BUG=444089 > TBR=jln, jbauman > NOPRESUBMIT=true > > Committed: https://crrev.com/b8be3a268134f32d667b42ea60a27c0084063873 > Cr-Commit-Position: refs/heads/master@{#318610} TBR=thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=444089 Committed: https://crrev.com/b38adbcfb38e56ef02f4fd6c3ec0f7c1d2a279d2 Cr-Commit-Position: refs/heads/master@{#318613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+434 lines, -253 lines) Patch
M content/gpu/gpu_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M tools/clang/blink_gc_plugin/CMakeLists.txt View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/Edge.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/RecordInfo.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/test.sh View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/scripts/blink_gc_plugin_flags.sh View 2 chunks +4 lines, -1 line 0 comments Download
M tools/clang/scripts/package.sh View 4 chunks +7 lines, -5 lines 0 comments Download
M tools/clang/scripts/plugin_flags.sh View 1 chunk +3 lines, -1 line 0 comments Download
A tools/clang/scripts/repackage.sh View 1 chunk +67 lines, -0 lines 0 comments Download
M tools/clang/scripts/update.sh View 9 chunks +352 lines, -235 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hans
Created Revert of Roll Clang 223108:230631 (+revert of r229678)
5 years, 9 months ago (2015-03-01 02:25:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970623002/1
5 years, 9 months ago (2015-03-01 02:27:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-01 02:27:45 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b38adbcfb38e56ef02f4fd6c3ec0f7c1d2a279d2 Cr-Commit-Position: refs/heads/master@{#318613}
5 years, 9 months ago (2015-03-01 02:28:39 UTC) #4
Nico
5 years, 9 months ago (2015-03-01 06:11:32 UTC) #5
Message was sent while issue was closed.
lgtm

I suppose the silver lining is that we only found the one thing we already knew
about and nothing else :-/

Powered by Google App Engine
This is Rietveld 408576698