Issue 970613003: Revert of Improve tracking of bound FBOs in GrGLGpu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 970613003: Revert of Improve tracking of bound FBOs in GrGLGpu. (Closed)

Created:
5 years, 9 months ago by robertphillips

Modified:
5 years, 9 months ago

Reviewers:
egdaniel, bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Improve tracking of bound FBOs in GrGLGpu. (patchset #10 id:180001 of https://codereview.chromium.org/949263002/) Reason for revert: Experimentally reverting to see if this is the cause of the mac_chromium_rel_ng roll-blocking failures. Original issue's description: > Improve tracking of bound FBOs in GrGLGpu. > > Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0 > > Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589 > > Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef TBR=egdaniel@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/73165bd417d6cd4b4513df54b58e23e33f151a3f

Created: 5 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+242 lines, -350 lines)			Patch
M	src/gpu/gl/GrGLGpu.h	View	4 chunks	+17 lines, -36 lines	0 comments	Download
M	src/gpu/gl/GrGLGpu.cpp	View	33 chunks	+184 lines, -185 lines	0 comments	Download
M	src/gpu/gl/GrGLNoOpInterface.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLRenderTarget.h	View	3 chunks	+22 lines, -78 lines	0 comments	Download
M	src/gpu/gl/GrGLRenderTarget.cpp	View	4 chunks	+16 lines, -45 lines	0 comments	Download
M	src/gpu/gl/debug/GrGLCreateDebugInterface.cpp	View	2 chunks	+2 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

robertphillips

Created Revert of Improve tracking of bound FBOs in GrGLGpu.

5 years, 9 months ago (2015-03-01 15:34:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970613003/1

5 years, 9 months ago (2015-03-01 15:38:09 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-01 15:38:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/73165bd417d6cd4b4513df54b58e23e33f151a3f